[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] acpi/pm-op: make do_pm_op() decl available in pm-op.c
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 09 Jul 2025 13:42:08 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1752061328; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=/a/MRMO2SeqBX/KI6Ggj8n93MtAuYSXovKYnqhDsEy4=; b=GJT/cr1Q8mUFA4DVxADZY+0nz3MbLu6MaQFcGh8QH4oGP6QDsxcspAOU0UAFAXbFBrOG 4kbMrg+h/YKic2KzjPyEJ49zgPi2ww+DdwoFPoZeBRfXjM6sSSmz8krNiLu5ViOu58xwW zGIBeJWB90k4EV15G+XRPsrcyMFL7v+kJ2znCC/t5bxpDAsxdlVhFWmrDD0xMDglL1JNA XERvxGzpdXQwkVVorrCSPBQDKk4N4Fm/tft1/jBwB7zabnslGsNCWLnxhU+4BCsTO+0s1 b3onIbghYqNUv8ACmgruMDEsVuSUqozaMBGQOF8X8qsDkkoHEQA6IRqXLAXWChD+q3Y7P /luxek5o2nyFv80vGtPeIx2KlftgQuCk1DTPIukij/2EUII9P9l5ngBuivSh4AhxXiyre 8Icg8LjSADnWZBMRapj3M+gn4IIzZ9Qainl4rW912cw/fjbsfRXWI7jc/hSBiXRL/Bohv TjCrYLfg8D/uhxyJ+OXs9NzB5D79YnVEmLIyVEUzSJ1Es1cVxpgnciKOtjZ+AWnDQZPqa sMMl+TCNSuc3GN5dgPcreZf77mwjntlPl1GFLWVKlVoFrtdOJaAzfoHFjfSwUphfOPUBG BBK7wY2JfUfPq9MOFq4lnQSy9WKp0A1BUWXg9NH4jA9X3IjpbC+gTi3P5cwScrA=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1752061328; b=vI6OAbfaETfHVcXNlErysCb+LptYOq1urkVqX7uXF+X+aSg0B2l7RW2J8Ph6t6/yf1wU sbYRxezZiGqGPhs0z5EaZOK9Cj5LkTjoqtU1XUGgeFA2Db5I3b+9F4mXZunyBMliP8jXH 2IZCiO7OhRFNFA67P+ewQpaRT2m7FZFphtaFJhtHc5rwssrZO9khuM4EoGcSXInQdO4Ij 7KEV24Id8QQlR6uI1aKGP7pEeB+4JY6V1bqvwKZVAOgZO3QmAsPYTUD5sToBC5DZpzLIN 8GGqJ75m3vW42vVzr+txC38R7poQIcDs4seMU3l+v++wJ7PVocJpWf52RcZn2EB7tB9ke 7o3Bk4/CWOO2Ed8S49x7l1chW/HSMCi5SJ1kwQYagnH8dgc2VPzwBhr6gGXb3ZBlwr9do 7azswjobN7EFvA+e8Ep4CABddY/Y4d+vw3LBLCkycXfh0BmW7ya7oT4tc1sHv/uvtxlV2 tlUzjsFMl8PZpv+9x+5min7gZKOMLMfsdo5mbQsghj89F1UnfcHoJfkgGqSl/sfrG6+Vy qgmKUhJemCpu/rls6W/w/bG0LL07IgPnkVsG0fZ5G5Tmkm3J17uXj4lHsHGXsJBWaSd4n 65qZCv1PGJtKsEJdfNumh6S4ARXhpx1xMmdO9kwAIVoO4Dty3oIYRGxLsm9X5l0=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Penny Zheng <Penny.Zheng@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 09 Jul 2025 11:42:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-07-09 13:41, Nicola Vetrini wrote:
On 2025-07-09 12:10, Jan Beulich wrote:
This addresses a Misra rule 8.4 ("A compatible declaration shall be
visible when an object or function with external linkage is defined")
violation.
Fixes: a16f2b3e0669 ("xen/pmstat: introduce CONFIG_PM_OP")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Perhaps a comment with the offending function would have been helpful
(do_pm_op).
Oh, nevermind, I misread the patch title.
--- a/xen/drivers/acpi/pm-op.c
+++ b/xen/drivers/acpi/pm-op.c
@@ -5,6 +5,7 @@
#include <xen/errno.h>
#include <xen/guest_access.h>
#include <xen/lib.h>
+#include <xen/pmstat.h>
#include <xen/sched.h>
#include <acpi/cpufreq/cpufreq.h>
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
