Re: [PATCH v2 2/3] pci/rcar: implement OSID configuration for Renesas RCar Gen4 PCIe host

[Jan Beulich <jbeulich@xxxxxxxx>]

(sorry, original patch already gone from my mailbox)

This looks to have introduced a new randconfig failure, as per CI [1]:

In file included from drivers/passthrough/arm/ipmmu-vmsa.c:54:
./include/../arch/arm/pci/pci-host-rcar4.h:7:37: error: 'struct 
pci_host_bridge' declared inside parameter list will not be visible outside of 
this definition or declaration [-Werror]
    7 | void rcar4_pcie_osid_bdf_set(struct pci_host_bridge *bridge,
      |                                     ^~~~~~~~~~~~~~~
./include/../arch/arm/pci/pci-host-rcar4.h:9:39: error: 'struct 
pci_host_bridge' declared inside parameter list will not be visible outside of 
this definition or declaration [-Werror]
    9 | void rcar4_pcie_osid_bdf_clear(struct pci_host_bridge *bridge,
      |                                       ^~~~~~~~~~~~~~~
./include/../arch/arm/pci/pci-host-rcar4.h:11:36: error: 'struct 
pci_host_bridge' declared inside parameter list will not be visible outside of 
this definition or declaration [-Werror]
   11 | void rcar4_pcie_bdf_msk_set(struct pci_host_bridge *bridge, unsigned 
int reg_id,
      |                                    ^~~~~~~~~~~~~~~
./include/../arch/arm/pci/pci-host-rcar4.h:13:38: error: 'struct 
pci_host_bridge' declared inside parameter list will not be visible outside of 
this definition or declaration [-Werror]
   13 | int rcar4_pcie_osid_reg_alloc(struct pci_host_bridge *bridge);
      |                                      ^~~~~~~~~~~~~~~
./include/../arch/arm/pci/pci-host-rcar4.h:14:38: error: 'struct 
pci_host_bridge' declared inside parameter list will not be visible outside of 
this definition or declaration [-Werror]
   14 | void rcar4_pcie_osid_reg_free(struct pci_host_bridge *bridge,
      |                                      ^~~~~~~~~~~~~~~
./include/../arch/arm/pci/pci-host-rcar4.h:16:38: error: 'struct 
pci_host_bridge' declared inside parameter list will not be visible outside of 
this definition or declaration [-Werror]
   16 | int rcar4_pcie_osid_regs_init(struct pci_host_bridge *bridge);
      |                                      ^~~~~~~~~~~~~~~

We either need a quick correction, or this may need reverting.

Jan

[1] https://gitlab.com/xen-project/hardware/xen/-/jobs/11087233227