[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] pci/rcar: implement OSID configuration for Renesas RCar Gen4 PCIe host


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
  • Date: Thu, 21 Aug 2025 08:39:10 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L5BwtJ6fvGCjGfbUbzoxAy19zus59Zz3J+RONBmP4C8=; b=C/17HO7sU9bsNlYjBnIIfY0O2frJE8gtq+dqK0Dfb5eLgxbxCXvtlY+JL8ys6SVXnbfo4p4iF71Ggywb36H8RNa3UGyoSmTuByu5aFCjj4I3SBwa5LO1UrD3HJibhU3piJofMpDjEfcxCoLm+7Aj9NS88OzzcuNeJ0MAsEXCdk2JpAE5y4BGfKT11Dom/WnwZtn9v0werBFBa69yllUQ7L0jqAhwT2FBhR9H2Jlh1rk6U2XtxYrToEtqZL52lnNoI3ZkrJKqXB9FkGbeUL2ewlKDzL7CT7g8DM+4uokY9HUs+kAWwDoERs8HwR/OeKgpVvDUlPWFz2WpYxeZkO+cfA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MFTU1aWQJNrEN6cuDPkeCdiLBbbcZ5nn0UFoZU2C6mUoVuFWdA8Rv5vLeP/r0tr3b4lsUQfHS+RVER9lKlyGhuN07+JUMHnKwv904HbtO+didbMMLDy8ov+6lykgF581eik1L+khTDpiomeQ0U7Wud6yHLFjxkdYulvFEQxgfHdo/8IiZyG7HBNNnz3LEvW13Ez5kYTyZDtegp2rn55DxZnukaz+DGDcd05AgSDdIE/vfmxFxEiIfOCFMJ9d8jSOkdInAs15A5y9PzXLL5GIBDNbvxs48yIsbgGEu3zR5dpFruAFx/xTJgpCPaU8wPnJG9anS5Ay7NM63rmUMeqQhA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 21 Aug 2025 08:39:25 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHcEnVb4pd/F3Rt1ky19lQedFCtvLRsyTSA
  • Thread-topic: [PATCH v2 2/3] pci/rcar: implement OSID configuration for Renesas RCar Gen4 PCIe host

On 21.08.25 11:26, Jan Beulich wrote:
> (sorry, original patch already gone from my mailbox)
> 
> This looks to have introduced a new randconfig failure, as per CI [1]:
> 
> In file included from drivers/passthrough/arm/ipmmu-vmsa.c:54:
> ./include/../arch/arm/pci/pci-host-rcar4.h:7:37: error: 'struct 
> pci_host_bridge' declared inside parameter list will not be visible outside 
> of this definition or declaration [-Werror]
>      7 | void rcar4_pcie_osid_bdf_set(struct pci_host_bridge *bridge,
>        |                                     ^~~~~~~~~~~~~~~
> ./include/../arch/arm/pci/pci-host-rcar4.h:9:39: error: 'struct 
> pci_host_bridge' declared inside parameter list will not be visible outside 
> of this definition or declaration [-Werror]
>      9 | void rcar4_pcie_osid_bdf_clear(struct pci_host_bridge *bridge,
>        |                                       ^~~~~~~~~~~~~~~
> ./include/../arch/arm/pci/pci-host-rcar4.h:11:36: error: 'struct 
> pci_host_bridge' declared inside parameter list will not be visible outside 
> of this definition or declaration [-Werror]
>     11 | void rcar4_pcie_bdf_msk_set(struct pci_host_bridge *bridge, unsigned 
> int reg_id,
>        |                                    ^~~~~~~~~~~~~~~
> ./include/../arch/arm/pci/pci-host-rcar4.h:13:38: error: 'struct 
> pci_host_bridge' declared inside parameter list will not be visible outside 
> of this definition or declaration [-Werror]
>     13 | int rcar4_pcie_osid_reg_alloc(struct pci_host_bridge *bridge);
>        |                                      ^~~~~~~~~~~~~~~
> ./include/../arch/arm/pci/pci-host-rcar4.h:14:38: error: 'struct 
> pci_host_bridge' declared inside parameter list will not be visible outside 
> of this definition or declaration [-Werror]
>     14 | void rcar4_pcie_osid_reg_free(struct pci_host_bridge *bridge,
>        |                                      ^~~~~~~~~~~~~~~
> ./include/../arch/arm/pci/pci-host-rcar4.h:16:38: error: 'struct 
> pci_host_bridge' declared inside parameter list will not be visible outside 
> of this definition or declaration [-Werror]
>     16 | int rcar4_pcie_osid_regs_init(struct pci_host_bridge *bridge);
>        |                                      ^~~~~~~~~~~~~~~
> 
> We either need a quick correction, or this may need reverting.
> 
> Jan
> 
> [1] https://gitlab.com/xen-project/hardware/xen/-/jobs/11087233227

I will take a look into this, thanks for pointing it out

-- 
Mykyta

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.