[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools: init-dom0less: Replace err() with more informative messages
- To: Michal Orzel <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
- Date: Tue, 7 Oct 2025 11:11:56 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IRBbOsAQzRdP52mgci1MzF2yRKWRNEkie8mPHxmMbos=; b=VM7Xb0IzaHRGDqkG63vPErMTAtJQTRaZVHYBNEqIYliwhheFbh68xdy7LIPBYqClg9P0gtQGmWiSLCeS41vjbrkqVx0ui0InB7pH4Fhg3iECMTRtL4zQz6uuPDA0J7/UMcBSJFrty5DEu0JfMxTnASEWykbVg66qEDddDkbcYbR7KA2mrbJFU4V1r4v1xuPMznQVqkf3TDlRjPwW7TLn3omqwqai7DfWNEUxbo4+ymJIG2WvbpKcLWflSorr5dINesssbjzDP/3E72iIwsZWSGzmt2MT9VoyH2HcgwB/tOs2ZR3P7zyULwZmfsta7xUlnDhyXvEyoARPwJ3l97/7Bw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ciwAlPwn09IbnjO/PiQ4bNA2pzn7pYf1H0aM8Lov/GOehipfGgupsvTgPUu+5aTyg53GtDTSZJ46Zl8FmZWes1fv+nDWTEHyYMHrWJBfvdlC5RhHammHbLue/8t5sS8dyxEBoWsjzDPtV4qBXrENGxmb5Y8O2i/ZL1es9phwVHCU40h+gaEw42YVQtBXhgVk1t0kzzmg0U7mzwC96SrGtADVepcUVVQh14421bq0ZHpyAEFJUC69eVzS53JTH8vv2uUaIyuAnhdShsvvI6OgcpgmfungfsWvFwe0D88/wTWbDfge27L9k0rf/XhyEWUN/LOlUq/QIdn8HfAQ17xozA==
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen-devel <xen-devel-bounces@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 07 Oct 2025 09:12:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue Oct 7, 2025 at 8:26 AM CEST, Michal Orzel wrote:
> Current use of err() has the following issues:
> - without setting errno, on error it results in printing e.g.:
> "init-dom0less: writing to xenstore: Success"
> This is very misleading and difficult to deduct that there was a
> failure.
> - does not propagate error codes to the caller.
> - skips "init_domain failed" message by exiting early.
> - early exit prevents setting up any remaining domains.
>
> Replace err() with more informative messages propagating rc when
> possible.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Alejandro Vallejo <alejandro.garciavallejo@xxxxxxx>
Cheers,
Alejandro
|
