[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools: init-dom0less: Replace err() with more informative messages
- To: Michal Orzel <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 7 Oct 2025 08:20:26 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kq/iAHI1Bxpklh5EIETLcC+sujxXJLQTOKNOuizR3lA=; b=p+5bfsbiwNLMTHNz0IXY0eG4yXNhIbiWfWGtwgNh6mREcz7VW743m7AxOPZtESMW4m0YkUN7AfeKTa9ROTP/m+qqqsWQRB3iM8k8jP0b5LjcleSCYidG9OlfjkmHXwLk4rjm21OzuCHVlpZzoJfX/AeKChRNuOQbnux2FCxPQ5uFvlYMGtDub372Ce7rR5Wh2ymrO4ic3SPGX4m/iWrzjI9Xqzqc3sIxNp2fLrhCmg/3MIlxGVGXjrR40PQyuWUrr9uNVP9/pXnH43HD5AsGVJd5apEt/nZTICaGEHPqaceKUUEowR1ll+wcFexYumkt9BlHyDDPrQYF4J3npZOsOw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yJwjV/AZU5y3tQ+w6pVvu0wDSrxFkhzrgH1UOb496Zu3oI8BQ4657fsd0cVUJelD4sZ5UtUpfiS4fSJV0EI/j/LkgVo+a8rjoAi1mepEJNRJ98ALZNXgBsABr9Zkn32AvTgQx2qZfiXOrfvMW+TPxhBhDyT5GQHQBMaJ3WK3xMJaQUK/cKYgtNIYuphz/QWRrxuDr0ta+5C6feqzFtr/jwr2aytu943XEzqTQLbwOAVWKKbysvZfpPZ73zwRVjxNqCi34/YqFlN5cMg9/iPFEmu7iK4uIa7uFmojlPE2Slkb+gJWwnnkfYPBrJJN2g8YhZo91pK8Jn5qJwbTRjuRpg==
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 07 Oct 2025 12:20:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-10-07 02:26, Michal Orzel wrote:
Current use of err() has the following issues:
- without setting errno, on error it results in printing e.g.:
"init-dom0less: writing to xenstore: Success"
This is very misleading and difficult to deduct that there was a
failure.
- does not propagate error codes to the caller.
- skips "init_domain failed" message by exiting early.
- early exit prevents setting up any remaining domains.
Replace err() with more informative messages propagating rc when
possible.
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
Thanks,
Jason
|
