[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] dom0less: Remove redundant magic check in 'check_partial_fdt()'
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Mon, 10 Nov 2025 10:59:29 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KVmkuwZAOk2BI3BVRgitWWF9v+5Te2hQ+t8u3r847dg=; b=zDi0AhmxYxAaICkFSx/EUPTL0pts8O0b0VNpW9EsPK+qJ1s7G/b6ZR0/FqHp/kVBK+052tQKjnPIiOlRAz9PyR1XSui2c+XSs/9+1LtPCu6h+9TqlDwSTwTLVOXkUnLE/XxNax3scCkDNOyNvRhWzGGAq1tyNjFmR6TC3XCV1t/pBfE+gVidARewx0C51qWg8CwNgjCCuaFjfYDPEa/10LgXQzltEoabwBlt9PL9jO0wHy3nRdxN4oAJvQj2vWS7LJY9UO3Qoa4RM2xi0fv41CkWgzxGEc2ZRilij1sZ4/9nEjEIzS6lQ/2m8UejV7cR+4eKoXpxr4pumXIooMao5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jBxcM52Du91//d+df0q/FSY6SiHD2gwjtwaPblXzVyv/we9wWgAuC/SaMsMUuM58DhxuESpZI+9ygyVuzbK/1LDXuHRs654h75jZxEEQPFalFxzjAFMnAopf94YI+2m5ZuK4jjKHXQuEMUeHDRHX2kDgHB65NdKjyzfdzd/IWqamdgPtjGTwq+a6JluJ4VRtOmVuM3wmDAV6nr7RjQVYcDZqQevinlhAAM96Jm3qkRYbtBXTBYlO9wfSMVziN0ZOGLUh9tcTIS5/2vZB+zvcdS/59ozAGa+s3TIm5f6jR2ogkAdD/BxYCrTgDM5iADb/pyj8rlCNbyTQZXQAREBJFg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Mon, 10 Nov 2025 10:59:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcUjEWFoN+6Y8Er0i5/VElc9NTMg==
- Thread-topic: [PATCH] dom0less: Remove redundant magic check in 'check_partial_fdt()'
The function 'check_partial_fdt()' performs an explicit check for the FDT
magic number (FDT_MAGIC) before calling 'fdt_check_header(). This check is
redundant, because 'fdt_check_header()' includes checking the magic number.
Remove the redundant check to simplify the code and rely on the library
function to perform header validation.
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
xen/common/device-tree/dom0less-build.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/xen/common/device-tree/dom0less-build.c
b/xen/common/device-tree/dom0less-build.c
index 9fd004c42a..2600350a3c 100644
--- a/xen/common/device-tree/dom0less-build.c
+++ b/xen/common/device-tree/dom0less-build.c
@@ -359,12 +359,6 @@ static int __init check_partial_fdt(void *pfdt, size_t
size)
{
int res;
- if ( fdt_magic(pfdt) != FDT_MAGIC )
- {
- dprintk(XENLOG_ERR, "Partial FDT is not a valid Flat Device Tree");
- return -EINVAL;
- }
-
res = fdt_check_header(pfdt);
if ( res )
{
--
2.43.0
|
