[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] dom0less: Remove redundant magic check in 'check_partial_fdt()'
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 10 Nov 2025 12:39:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zl+gm+3bPs5uAyz/cGBK6PuqjQ3RKuaPZ1eB12/9J5E=; b=L99rCkLr/IYm1opq/tMbwV2WpbV1e+3AyGY2gPMLw40+GhwD4/NoRX/Rh3QBZdMWMZMdrvEzmL7w41S8jX41E+bClxS3Vy0aYr4syNg21Sb/nTWMe6uXyPXKvR9lOYW5b+dUllGw4SvAxT5ngGrYlXivGffmRv3fYfGWImVP4s17z7/uwiF5MCruvktEhjkAplPET8TlyFaVWo5E6U6oHnByCx9+8N4hXHM4QEOaTNiKMIOEb1XMX7i8cOzTLJKyeMJ37WFunGkXKiUCylx9q9lWWYrs9wEmoeefro/nLTr42OcAbHYNj249Ky3W4zhsaxaxEgzLr9DbsH001YhXuA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aSUqiKx8x+ssJQLwt34GK5Vw/L5R7njKUQW3xDguJ7S1iCoHK9mFFZBgd2s8B36hQftzqG6zLRTyJ6f/AhULsz82nb7MgiGq4+4Hokbw9a9aNCMdVGO9ISBsfnW0UGUuDkJkQmCLDeTHbwWd4WFYGkVe3J3DNFnzw5NnO7IT0gSHhbsKp42wdJBLOL4mg4nrggw56sOnTNDCDP7VEvIl/nVSd4XSJRuukWKB1ciV5dNT0mLhBnYQTNcQD8I6yfeCd5zE+LXXUN3M07KWLTDzd/HVFoOyYHYoV881Zdp4Ilz5jh6jOAfO8t7bx+u4gY8iiD81aRQSdzJNxplhl/X7Eg==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Mon, 10 Nov 2025 11:39:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/11/2025 11:59, Dmytro Prokopchuk1 wrote:
> The function 'check_partial_fdt()' performs an explicit check for the FDT
> magic number (FDT_MAGIC) before calling 'fdt_check_header(). This check is
> redundant, because 'fdt_check_header()' includes checking the magic number.
>
> Remove the redundant check to simplify the code and rely on the library
> function to perform header validation.
>
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
