[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Use FDT_MAGIC from libfdt instead of local macro
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 12 Nov 2025 07:47:27 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pch2KVFYJZ3k3jnuyzWiscTST8PxHu8Qog87IinwUxs=; b=Il+rBNjYz1OdXX/OJ9++ZUL4GnFSKOi87ZcR2hKrQH8ieQa0mMZ7qG4H/JCsdhWONEwRLbBcB4978XIV6UlDq9uUaJAatrqfBB5Gsi1qiX+XeWluQAMWxHNV2TiuSFpWxwL59ZouCylxKiTl3MaT2FgpiOjBlFeE6PAnpZddMnm1CTTwds3aFawN3fx04H8u7wjB5Ekf97ligzO84N/stAsgGx7/yKGyxynQWmEItt+OHYqFCw9b69xhP2Ovz+D43sSDnpqVplGbJZ1xa0BE4xlCDpo2YEGGxQZlHT8EYLZFJrnEspePJhjIkV5wrkWxgbXWWl6rTdYgb3FSWRJZ0Q==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pch2KVFYJZ3k3jnuyzWiscTST8PxHu8Qog87IinwUxs=; b=AGbTVnf4ljmpBTY1pUYMclGcx0fKN3iCVAvh6SOP5+vDzfY38RTMTBBBk2ek/NSBb0ceg/Lv2m2yTx/sML46tNNYw8xc00liwWxkd9ycWisU8ZVzNpa7pm7KdV28hJyQfsnQEFwcm5jjNIfIb9jdmHUVaqzzrkXBnPYrn8Ng7MTTJowro7P4uP4A9IinK35yl6ZjcC44h4YhI9ba7pIEmuI23VPT2PH+xFTuuxl/5ltYvhJ5lvhjwV98sRduBpPhi+zDFtDU8PWXZRtm5h7+ZrzBgAvRiIW//7gmnjKS5sy8kDNlzB82KjUgERfnEsFgTBRpGtdRmAOqY5etjyl/tQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=OtefcMgUsG+rlmB6v05xDJ1dv38G49qpc+HzgYcR2P9LBA+aukUdNfT2JHKTUwCqwuZMxYKP+BvAI/o/cSRntyh0H63S87CAu68cfP0CIuOoq7wGSGgqDKkkpDNYsyZB8wXtI08YjRmgqrKPOAF0xSZeWmykXCzCv/4I3t0YmbkRtfbYW3uE/6jNnQCSLSMH+5gN+mvzrGsVsJ9rwOM0ufVNItHlTH1SmgZtE25OcT6VOd2h/3HP0io5INoklTTa7EQS/FcOOQ2zhkX4IQOgpBYER6tv8LyxfUE5REoZxuB25NsSGGF29DxYrBrPxPCs2757WT1mppK47bJx2VwTVQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DxTABJgEg7u9x3l8W5KKqC5TY1S7kw18C7HX0/bprqg4YN+f9lO+pH/4P9Fp+Rgi0/XMPpW8w0LrXlhzLMitM2xADI3ccjNqtL0LWQt6614wqqbA+IsS4waF7yxHZdocwXvIuhOiNs6Xo2Z3Z8EM/RgJQ3PjoEm8jjg02LF8MXDj+tNSB4qZWVWZ1u+INjNKb7PxrzzIOgBCf6gkVEjudQ5/aVIG2F2MbxKLT6VH5ztYN+w4ZOCS7IAE7TtKsPEKOSg7pPjribyugz09caML/82cOYol14l+Qh40MFgisZQzB2SthiAIhDc6Pi1sncMFzIKr3ZAhN9dHk5Svlvbtog==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 12 Nov 2025 07:48:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcU6MU9r1SyxgepkCxXro0WqQYWrTuqdCA
- Thread-topic: [PATCH] xen/arm: Use FDT_MAGIC from libfdt instead of local macro
Hi Dmytro,
> On 12 Nov 2025, at 07:08, Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
> wrote:
>
> Remove the redundant local 'DTB_MAGIC' definition and replace its usage
> with the canonical 'FDT_MAGIC' from 'libfdt'.
>
> Fixes: 66edeb2e3972 (arm: copy DTB appended to zImage)
> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
> ---
Looks good to me!
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
while there I noticed we have DTB_MAGIC that seems to be not used in the
toolstack
xen/tools/libs/guest/xg_dom_armzimageloader.c.
I don’t think that should be addressed in this patch, I just wanted to raise
awareness.
Cheers,
Luca
|
