[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Use FDT_MAGIC from libfdt instead of local macro
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Wed, 12 Nov 2025 09:15:24 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLnFpXyUB8/COLBPlJenNeNEFAicpjBvy8JZOhSkedg=; b=rUipHGZ/dX71TtTAvtSI1mZDPuvw91g3FYIPl1ByHUIN7ptV2b6IO5bIvovj+JcrniAd8I1nwa3JcfbCtC5iZAHmBxeVWvGLdvourAunAudWq2vd8+OVStlY7h0v+0YnK4ZYqE+5po25NnVscHRxP4jvwA+SiLNihVowFW+9xf9VlKX9rTl+saTr/gCQ2ri4iLDF3eh2pEAu39+O+qlTqTr9oOu7O8nRTeNtP37qm86x/n4HcbOqXnn2xu5WMDPdxvg6tQG2XUr/pH+z6lLS6ieNhdwpKMXgFOHggmJVhrmZo63cXq6gS1SWCecrt9eI2WdKS/GZZOdAIprqaq7EVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tqZvjjanhvr1FTsKMgwYcr+cYGgsZOwVR4gWTxVxX0NHvbG5N5n4kV60bqxuQBiVCxZpP8rSkAic8uSv2tzmPvoVsf2RwyqNbmAAuTxKk5Jneap8HqC4M2z1+7hMSr/PyS1fdTtOWapUdQFtkKwuLN8l5GpbmGS/U7DXpQlmMm6ThhWmFgJr9fD+KZjQzOscQ6kUq/1txEoLpKRxUOZlD2tZm0hDDCW9MuHv//Gg0VJruORODPEF16QuiURtvpAd0net8mfsJ5V/++Sm0EdNzv7i3msjecGMG7CKfwXhKl0qxyBg6WreXkGbCFEwCNR/c5gYoi1S0tbTC7jYgSA9ng==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Bertrand Marquis" <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 12 Nov 2025 08:15:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12/11/2025 08:47, Luca Fancellu wrote:
> Hi Dmytro,
>
>> On 12 Nov 2025, at 07:08, Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
>> wrote:
>>
>> Remove the redundant local 'DTB_MAGIC' definition and replace its usage
>> with the canonical 'FDT_MAGIC' from 'libfdt'.
>>
>> Fixes: 66edeb2e3972 (arm: copy DTB appended to zImage)
NIT: Fixes is for bugs. Redundant macro is not a bug I believe.
~Michal
>> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
>> ---
>
> Looks good to me!
>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> while there I noticed we have DTB_MAGIC that seems to be not used in the
> toolstack
> xen/tools/libs/guest/xg_dom_armzimageloader.c.
>
> I don’t think that should be addressed in this patch, I just wanted to raise
> awareness.
>
> Cheers,
> Luca
>
>
|
