[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/4] xen/arm: vcpu_vgic_free() updates
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Mon, 29 Dec 2025 11:50:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SxNag1C1nXyceWhu4QJM6GmgLPpj66DrvEE6xLUTqYo=; b=Ab0w7nyB3/T4hMd3K4dE0mNVrXVDCW1q59olc+sWShpKphot60GPutJ8wgUwUn0IxPaCQYlONbed21FAEDmYBh4Dupv7vlV42aoiELFgrFWkufkgT6mZh1jJX8Da7msnUXT20qo99/n3GDrRkIvyo0XMZ2x410Asn7yZvip7XUaDwxxzzWDGz/dp4BBCL8kzvPxL50zswKv0Jb0lmVTnWyJOr3ABt2leCXN4VXxd6cE8qTYuMndFrZBkV4AoXkz0FDA4LFrtbFl2T2sUioL5exVcxj7FBDY3Dkvrv368iEgbc7eqlwEP6w3XFuEWxAJ+gIN/BcL8ZLyp+Sylrkc/Fg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rLs/j8NvX8Ta+GX+gVbH4gAgRvmIl0YpDm/XwDWPbsF0OO6hbxVl/fOOMc3nq8EL/+Ev4DIh2Y/Pb4kjOVeDdOVJ4ARiKkhCSfIfmaWo/C5g5FkDe05wk0sgo4t4dOXdPo+ISYXcIHVeopJZHl/vJDPWMQL8qnDckp0z6MUDBfVXPLN0bibL+rwc8tMfm9YIOLTCDdXgwuoQxm8MDRzQWC+1+HmB3yLZuUUkke71Asnkmsi5AXcCJRWxKpJgxtnX1Aiz1VT/MqjpROb6UH+5nBrUiRC/hBcI4dT6bihuDBdbHjOl+iXrLypioIZV1PgnvSjnQYsWR8N3858BfdygUQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Mon, 29 Dec 2025 10:50:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23/12/2025 18:01, Oleksii Kurochko wrote:
> Use XFREE() instead of xfree() so that vcpu_vgic_free() can be idempotent.
> With XFREE(), vgic_vcpu->private_irqs is set to NULL, so calling
> vcpu_vgic_free() a second time is not an issue.
Usually it would be beneficial to back such statement with an example of a
situation where this is or will be the issue.
>
> Update the prototype of vcpu_vgic_free() to return void to satisfy MISRA
> Rule 17.7, since the return value of vcpu_vgic_free() is not used by any
> callers.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
