Re: [PATCH v4 1/4] xen/arm: vcpu_vgic_free() updates

[Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>]

On 12/29/25 11:50 AM, Orzel, Michal wrote:
> On 23/12/2025 18:01, Oleksii Kurochko wrote:
> > Use XFREE() instead of xfree() so that vcpu_vgic_free() can be idempotent.
> > With XFREE(), vgic_vcpu->private_irqs is set to NULL, so calling
> > vcpu_vgic_free() a second time is not an issue.
> Usually it would be beneficial to back such statement with an example of a
> situation where this is or will be the issue.
I think there is not a case now in current code base, but just common practice
to have such type of functions to be idempotent.

> > Update the prototype of vcpu_vgic_free() to return void to satisfy MISRA
> > Rule 17.7, since the return value of vcpu_vgic_free() is not used by any
> > callers.
> >
> > Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks.

~ Oleksii