[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/5] README: update minimum make to 4.1
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Edwin Torok <edwin.torok@xxxxxxxxxx>
- Date: Tue, 31 Mar 2026 18:53:04 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WJrwMEkRQFsBCNOtHa4+e+DOo8IJiDMWUuPBfNAAYXU=; b=So1zlMR6g05dF4qmoU74sRYbeK8ltvCJR7BbmkANMk5U4K+46WN9tBgZAi+7Lfkg8BKyCKmn2M9lmyCPu2CtVk4C5EZkGPO7g0y6JKogXH7EQtarN0kZNMA08G/R74BG+oHPKvV6q7K7PNuyrxXWEGkEgGb0om0Bhf+olJHTVgieinjmNv95QtxjJ8qdzs64mNJo/IvKk4Im6UjZvg/zNnZwLehyyK9j9Bidq2FVxnfpDRHnTswhv1uihNgdqPs7sQSk9aXjAQvvJFsuyMRk5Xkn5kEShusVRsJhg5teaF9XQOJBwTr3qgFJbOZchwhWvnY8WD2cCTCZO2efRtlhjA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m6Vqjyw6gOJR27TKqO6rctn7eW0gBawwkj7BJG72q9gVBNJgD8NhPhBjsj6A71oTX9hNZl5NVdiwAhkalF9BZrXvwUwVUsQAoORzRsZqstaeNdgmOPxk3+eFMiXX4Pgyzal7ppYsDbgkXzxSgYN5PV7VcsY+EXb4InYA6N/PTKB+I2gFT5zHiu8wfNeYugmPjna6eI0RDVIx+jHcJZf5o9kB0rnHvTcXne4dvrQihQ1OGSEVMn+GpNODZ/ZKvZW3kUczDA0IcbOR6cTuwiuEBmwQpp5u3KDKMNrk30TlspX6HTalkQQxL+1VD5s/CV6uFTRokwC7HsJ+dhxJAMiBAw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 31 Mar 2026 18:53:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcwGC/br3u5UUhvkGzDiCK7sswX7XIKoSAgAAhq4CAAAKTAIAAr6YA
- Thread-topic: [PATCH v1 1/5] README: update minimum make to 4.1
> On 31 Mar 2026, at 09:24, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 31.03.2026 10:15, Edwin Torok wrote:
>>> On 31 Mar 2026, at 07:14, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> On 30.03.2026 18:17, Edwin Török wrote:
>>>> Using .DEFAULT_GOAL requires at least GNU make 3.81.
>>>> It was suggested to update make to match ~2015 era gcc/binutils, hence
>>>> 4.1.
>>>>
>>>> Signed-off-by: Edwin Török <edwin.torok@xxxxxxxxxx>
>>>> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>> Link:
>>>> https://lore.kernel.org/xen-devel/c0ba57bb-0d86-4209-b019-daf8328b5205@xxxxxxxx/
>>>
>>> Unless we're specifically meaning to use 4.1 features, personally I'd prefer
>>> the lower 4.0
>>
>>
>> OK.
>>
>>> (which is what I have on my main dev workstation).
>>
>> Which OS/distribution are you using?
>
> On that particular system it's SLES12 SP5 (in LTSS).
>
> Jan
Might be difficult to get that exact version into the CI
(https://registry.suse.com/repositories/suse-ltss-sle12-5-sles12sp5 says it
requires a login), unless someone with access to that version sets up a Gitlab
runner.
One way to approximate it might be to use
https://hub.docker.com/layers/opensuse/leap/42.3/images/sha256-84d4bef2c4657b7bfb48233aa84f40e2303af0607de06562cf4afc496ec18b59,
which should approximate an older SLES12 SP3.
If it builds and passes tests there, then I assume it should also build on
SLES12 SP5 (except for toolchain bugs).
At least the version of make seems close enough (4.0-7.15), and that way
contributors can test themselves whether their patches build with the minimum
requirements specified in the README.
Best regards,
--Edwin
|
