[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Final series to make Arm MISRA allcode green
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 8 Apr 2026 10:51:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kyQ6vquH4hEhzKWsUhUTr+mSncIo5TDiuXFQYOLH/oc=; b=GbW52Zb0PO7zCQKdB/EacZ8uCkiAaY/q07xI6bs4mBjGCNnYi5WejHPsk4iAOWGnqkRz4dXjoKDFNwZneNLZ4zKFCKfLcUhiPT2kGD7F69LDuxEuvEjg2Qe5zysU/+CP9xgvLbZkh4dFBe4cu34GqEj9v2cuMUEQLaqp0f9fVOK5F9dfPTEFOjfy2WikMNzNQSitBuDnc4WdLUT4DfrwP+sw59HCPJTG9KN5QpAh0mbh/IH1s+3xguKTyQaaNI1+tWTHrLy/77VuBb7JCAxNcf0rSm/y36VXkAVcAfZMrYMs/CwDcjHtj8djtUXrdqEuxR8rJNNSU89wdeBfU7UOxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gDVtJ6Kqq+io+1yx/DxhVG7UrUlthBR2X3NHbQDk282ogMULlH0FTAwH4B+qKXGfTXbfWueo0XHv/nVt8WZmjYfuQEG6M39eQiLdWLTZqOHVGOaXDeE57uuZvimd8YAvNQe2I50byRDkdiwidWADLTCYQSPCS65mADcsBqBbT1vN4Fak2Iq42FcfnlOFJHUuBr/JbNIA62YlkzK/ZVvMWWTtTlM62IhVv3SAC4qDu3FJFrSi9PuzVAZz86Tl/y1sXB0ho7pQYC/Fw1heMIIIi2ajJRu82PxhyR1t5hm6eNGBDfVV//TmAcztKj1JTN1NWDd/OmcjeM7zYnOxFuqwuA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 08 Apr 2026 09:51:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/04/2026 10:46 am, Nicola Vetrini wrote:
> On 2026-04-08 11:22, Andrew Cooper wrote:
>> On 07/04/2026 11:34 am, Michal Orzel wrote:
>>> No more regressions for clean guidelines:
>>> https://gitlab.com/xen-project/people/morzel/xen/-/pipelines/2433943072
>>>
>>> Michal Orzel (2):
>>> iommu/arm: smmu: Fix variable shadowing
>>> iommu/arm: ipmmu-vmsa: Fix variable shadowing
>>>
>>> xen/drivers/passthrough/arm/ipmmu-vmsa.c | 6 ++----
>>> xen/drivers/passthrough/arm/smmu.c | 7 +++----
>>> 2 files changed, 5 insertions(+), 8 deletions(-)
>>
>> If all the violations are fixed, should this test be made blocking?
>>
>> ~Andrew
>
> Only if they are also clean on x86; otherwise an arm-specific list of
> clean rules should be made (probably better). @Michal what do you prefer?
>
All I'm suggesting is this:
xen.git/xen$ git diff
diff --git a/automation/gitlab-ci/analyze.yaml
b/automation/gitlab-ci/analyze.yaml
index 4e9af9d60224..f01798c5dee6 100644
--- a/automation/gitlab-ci/analyze.yaml
+++ b/automation/gitlab-ci/analyze.yaml
@@ -149,7 +149,7 @@ eclair-ARM64-allcode:
CONFIG_STACK_PROTECTOR=y
CONFIG_UNSUPPORTED=y
CONFIG_VM_EVENT=y
- allow_failure: true
+ allow_failure: false
eclair-ARM64-testing:
extends: eclair-ARM64-allcode
so regressions become blocking.
~Andrew
|
