[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Final series to make Arm MISRA allcode green
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 08 Apr 2026 12:21:07 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1775643668; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=4FUg+w0vR/wmXVAH7tfUoQGtkITJK7oPT0+fyci1VLA=; b=bAppOejTj7EXSCVypa4PQ7y9cPNoOGZvLyI6l6Z5Ns3pTzAtLt0Ts2VACyc0R+mgU7QY ia0I3a1rDGOdI/lXbOhd1P3uLT8E/nycUBWiBld/J4LpWCeAMQPbYeZ7ZJ363sTyN2OsV wf/KOIkLIOc7G2kuy/ZyCL7xkiEnMTTpL28wBruImux76zoEgkqA2K+S5AX8qUYJ1Rc32 Yf91Q6VKXeFy4+ymg7D7MCMaH72bveI4R1foM8RmG4yRzqAKZrPF8m0vSScvnN0c1T6vt YAiiMnzJwcD0Q5YcSyHlaKVrvm1dRUN/TpjdfrRxCBQ3Nlwyzvo1GAlm1TSS5BThttc+i dsoH0lPPshhTx9Sp0t1PJCCXdHr2xqtNAyxpJGU75Jis4sJGBbX0qk5JuySaN0bZR9/Oh kq++vXVTGEBMyrfMrequDuKFY1m1Mith7DfQycvgI54tU00LuqDfsSKZVOW2Qg2GuDjZq ZvHB8FH9XzYwOnYCaYBfz4+18d6y9RjPFHpOuDKio9HhieroNx//ptxE6uiiQIGZAT2Ht jiqHLdT83HTMl/S/ysdUYrIK/R5yt0df4vBhUAuqK39YWh0T1oxWGIphWPbkg0d8M/lfU RSLsWgmJOcIlNl8w0tpFIRedf9ysBOC5rl1YM0YZZNr4j/LkVsKAExT4OSyGQ3Q=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1775643668; b=DJTyujdeAsNX+NGzb6I5ZMeILL/I8afTuz1OuchBcQiPlahKwVEiAU3ic3Bj+02Iw8xv oh8DOYcynQ3PuRPAZFpW8XEqGf3KBiXjxnf4T3fB6/MM0dDtvn3x3YenFMD18D2Zesv/r Yev2gtcaAF3cdluZacrblP7cI4xXFZD5MYK7VMLicg1Ke6A/JM6mRNInnbF3RnVEN22xe riO+W4IpNaLajo54fzLkoK+vhPUJzSnWAA8j6ZsBWuFZpQRDYmHrdLKL72LTIsDqzYdq/ 619PfjjxWJwdRBa/SMKnsedbLiIo+HpZ9BERuQXDT0gcXGlAXBrEYfoeOZH8EmJqXhsxW ucZgAaawsqHTt5PKIZQnle5gbc5oGBbizo1rNaz+6h78Elirty5KKcIO0RUuSxuN5bmq8 M8i+rSqDLXyaDHBI4OsaA1vs8VzRrFWR4EcKnOeVkrtwP48Fu56MfLtAlrySc2gqb9gVV QEquF6MmwnHaSPbOSKq6ZQP/2+Y17G7VO343Gv6NmKozp2JllBEyp43+LvPPtCxpbryDm r7xUK0lJ36YZQrwKuYmNxKSdOfEVyFjPKBk0Dm92jcM/xGjFNwafeKDg6YokVYYkHYUmU Ue2QUs9Z7GCMYSUJu/k2tEEV7pK4zAHQVpP7P69YGcrvBsmDYk7RocyD2jBEHfA=
- Authentication-results: eu.smtp.expurgate.cloud; none
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 08 Apr 2026 10:21:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-04-08 11:51, Andrew Cooper wrote:
On 08/04/2026 10:46 am, Nicola Vetrini wrote:
On 2026-04-08 11:22, Andrew Cooper wrote:
On 07/04/2026 11:34 am, Michal Orzel wrote:
No more regressions for clean guidelines:
https://gitlab.com/xen-project/people/morzel/xen/-/pipelines/2433943072
Michal Orzel (2):
iommu/arm: smmu: Fix variable shadowing
iommu/arm: ipmmu-vmsa: Fix variable shadowing
xen/drivers/passthrough/arm/ipmmu-vmsa.c | 6 ++----
xen/drivers/passthrough/arm/smmu.c | 7 +++----
2 files changed, 5 insertions(+), 8 deletions(-)
If all the violations are fixed, should this test be made blocking?
~Andrew
Only if they are also clean on x86; otherwise an arm-specific list of
clean rules should be made (probably better). @Michal what do you
prefer?
All I'm suggesting is this:
xen.git/xen$ git diff
diff --git a/automation/gitlab-ci/analyze.yaml
b/automation/gitlab-ci/analyze.yaml
index 4e9af9d60224..f01798c5dee6 100644
--- a/automation/gitlab-ci/analyze.yaml
+++ b/automation/gitlab-ci/analyze.yaml
@@ -149,7 +149,7 @@ eclair-ARM64-allcode:
CONFIG_STACK_PROTECTOR=y
CONFIG_UNSUPPORTED=y
CONFIG_VM_EVENT=y
- allow_failure: true
+ allow_failure: false
eclair-ARM64-testing:
extends: eclair-ARM64-allcode
so regressions become blocking.
~Andrew
Ah, yes, indeed. I didn't look at the patches but given the diff it
makes sense
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
