[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/x86: Check supported features even for PVH dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 8 Apr 2026 12:22:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pypoFiR1BMj15sMVCp71mL6bnFBZjzvQYbP1C4FeNSo=; b=vt3hsTKzo+ueCge9Fb5TZiCr/BWUhsh4hLjuZSE3ZICF1mAw/0g1w2rziRvdBwT3crnSfB0vg4kaT266j6p4UeYACsonZoQz1qwCXRl0H8LStRDiCuurtSfPmQzxySTKvqyzsP5Qyfl57Z4tuvPql/lzgbxd8kCplC0ZV3kvPTAs8LQeOJUMnEgKfTrUZkTtLKz2Qh9fCHcCOVpoDg3MPqEoxuPAjGe6VqqnNTChy8XtLnpa27r2fd53BGo6Mzp5W4KGVU66iSRwmzJUlaXoLpEbdiO/a+Yo3pplxERY5KTnf8UEmApFU0PPil9TcQBaW5sd8Y8SXl164DWXhYZttw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=myhzkVZIL0XH6MDHQSA/xJpx00FIlEJLPQb7guRa+cHuXUTKg4x1JLNW2pO75/VIcNb7qT8jHJgAyY7jOCkEhJFKtWglMQgM3Vm2LW6Eqz8UVt8rcT8Z06Fdo7ffwqWauYcuxPIuO/PgZt+TK/aVcXe4F8kJgnbFR5NaJLZI2SKCrDBV8+cP4oHaLlw5doNLOfFOzCVO0IxZGAlzD+Q1EEjQM020KtpFCROGapgpn91YiVnsmJpCMCCZoWwCDuP1rHSNtmmuliSqkzJvWxb13eD4g/Rr+diMt6BYbMbYrtS0seWk5typxfJNb7CYwKpoGMekZHYQPGPRff+rXiZZUw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Frediano Ziglio <freddy77@xxxxxxxxx>, Frediano Ziglio <frediano.ziglio@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 08 Apr 2026 10:22:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Apr 07, 2026 at 08:56:03AM +0200, Jan Beulich wrote:
> On 02.04.2026 17:55, Frediano Ziglio wrote:
> > --- a/xen/arch/x86/dom0_build.c
> > +++ b/xen/arch/x86/dom0_build.c
> > @@ -320,6 +320,20 @@ unsigned long __init dom0_paging_pages(const struct
> > domain *d,
> > return DIV_ROUND_UP(memkb, 1024) << (20 - PAGE_SHIFT);
> > }
> >
> > +int __init dom0_check_parms(
>
> I understand the "dom0" in the name is owing to the filename and perhaps
> adjacent other similar functions, yet ...
>
> > + struct domain *d, const struct elf_dom_parms *parms)
> > +{
> > + if ( parms->elf_notes[XEN_ELFNOTE_SUPPORTED_FEATURES].type ==
> > XEN_ENT_NONE )
> > + return 0;
> > +
> > + if ( is_hardware_domain(d) && !test_bit(XENFEAT_dom0,
> > parms->f_supported) )
>
> ... if this was about solely Dom0, no is_hardware_domain() should be present
> here. Maybe s/dom0/initdom/ ?
I think the naming of the feature flag is not very useful TBH. What
is the kernel really advertising when setting XENFEAT_dom0? I've
assumed it was the capability of running as a hardware domain, which
requires a different set of functionality inside of the kernel to deal
with hardware devices.
We might want to take this opportunity to clarify in the headers what
XENFEAT_dom0 means.
Thanks, Roger.
|
