[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/common: llc-coloring: Fix off-by-one in parse_color_config()
- To: Michal Orzel <michal.orzel@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Halder, Ayan Kumar" <ayankuma@xxxxxxx>
- Date: Thu, 9 Apr 2026 12:57:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXExszMZ67RnxxH0ygAn7t7lzcVur9vBZUkHNJOVmnE=; b=xSJ9hfATKtEfokBJOXy0crMm8cWKQ8Mv8KszP9K51pzX/0wRyCm0bzYiJ6gkMcQv66WcwelI9OAjEbk4V7v1huuUuVjp6km388QUNCgOhQ0jnl3vxnkgRfwgjIKjhuuWW0eUk9SKHKXQGHjS/Yta92bHKMAI+/6m9ebSwqaHAwfaV4W0pUDHZdB1r2yNF6w6jdPBWQAG/t7bfj1WRXaqTFkh7Lven8Oa8ltflU+V5J9Bd9/hBLV9lUKaXWhjtVl90c+o6b6KJ0/7NAbNqQ6PWE7sIMtHTBK6clyYe2e1mz0sqzOw1pjk7F1MXczHNt1+BoGnNAMHZ+u+7frN05WrEg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ao8VUwdyLmKqzzbopv6Sdi8QfGdlabxeDXx2ZsnXoBGJcpwmHG8ehuVs5BaDpmO88wkHjVpRAr6sDIOoIbl8LZO8PWQxSTmA4Up62lKI8s14f9M47o/ePu0lxxHwuzKlLlkQsOOZlr5V4OwZRqlVjcsXRBNgO6VLEs9DA4VOe0itry8Y8B07yU3LD95KlPxT7QoSktbiQcjqyHJD+lzzpqfTDdOQyQ1x2U7x8/56wD6eIhOktvhPFBvIj21y5EaJvaXKNj7W+WvT2ReAbwGEfrsyQmiuH5JtgQZ9d0gRsLJ1RnR+cCKPPlEe6Ja7cu9UF1HDZBU6Xe74gUbXdTZehg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 11:57:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/04/2026 12:39, Michal Orzel wrote:
The check uses >= to compare the total number of colors against
max_num_colors (which is ARRAY_SIZE of the colors array). This
incorrectly rejects input that would exactly fill the array.
This seems related to BVA as well.
For example, with NR_LLC_COLORS=16, specifying 1 color for Xen and 15
for dom0 would fail.
Why does it fail ? Is it because the max number of colors can be 15.
- Ayan
|
