[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/common: llc-coloring: Fix off-by-one in parse_color_config()
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 9 Apr 2026 12:22:59 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ROx8QQJcwPWsFXms6bd60bnGVW/c/0+SxbZfnYXEMY=; b=n1fQN9pObs0QAEkH0c9+MPoEkeWuscNbpPClXU5s6TnysOFqNTyHGQCBnHbfMQ+tbSrVVAB1PbvYWEnrQlk48UJVadRfu/KEcW/D+KhLADO0tOg8ZVu1PdcQrAZHPyY9+P0CAECmBekaBv8fqJ22t820oIOsRlcreTfbzhKIs/0BUmP4/az1Y9g4LaRMftYJOd9uZ8Tm5J+8/UNBlbQ3yiqE9K8ADF9SiSaGZZEWpB1k5QWAVA9wUdPcFNL1Z1csSM3QlAEuKHqKlyZ7MskkntFSKelqD2PlZY6LrIEoFRnI548gfA1ItTCl5b0d3jlYOfE+kpM4khRFtN53OpHHQA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/ROx8QQJcwPWsFXms6bd60bnGVW/c/0+SxbZfnYXEMY=; b=yjCCTPC6ZK2lkCm8MB98sh470SJpq2CbhCpSxm9Jd+SxGWww3RXWSFILnVN/jTBYoVEAYt9nsR4ziL+gL8iR6V6j/XAt44WJbOzodqrvS3/TiFOkUknD65mNMNlzWiqCTZ5vVhl7eRdopfJvyhf070uPwZZjDQvkGzwhccOQsOXLGgSV+tY3xZU3OMlGMNf2et1AKkmBOnyO9cJx51jlLzik8jsXE7HEGnGreW6CczohHNsME3hreTpZYSi+Bp9cSh3M5Gp5hdXJht61wWp3MAmFY5XHus2/Fef0xTMgukkx/ZakLV9cV9ccV9PoYO68SDFX/8OHGpnpt0dbN8G65Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=W4CeHh5y5uUwp/ESN9zACyyCSBnnhbjbC7+PvE/L64+13XgWW0gHf4SX7Uznd4u8da5m+EMlVolt4Pd6m47R4Jvhv5E67IED/GCCecHvC+tBZ8GrSzQ8K1Rc+gqE57WS1Nbr3/EiH5fiVl2qxvK8WxYw4YGl3v2uqdXJEE7gwxdWX+UA2tcLMdg3k0Mtd9co4RI9sh5dEEJ/VGWTEjl4i8kyw4eAmiDe8RB2kb/NOKdrAo59yrwteNnHrFGQDE/iPxelZRPooh+sUWp9BTeraFhJmDPGddP4wdFSBSX/TbfTxVFcN5VoHcHq3YZSxo0qANS2PO+q2j7QIIoxl8UXZA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G3lM/MN7jMmyJLpgchdS7h6x0TvkdhIjHjeFsX5IuGA8ry6Hcn3cQgXr7cPeLOjhXogPqN/wEcMC0XB35gURC9Z6EJvWo2Pb7AFAvPsybG+KDNVLROwAcKKpgxmEHDk2TTXjLcBuQLO5xEFS6xA9csdr6Qc8kHo1VoShIqFlzOq+Z7WK5BH8waGKawzvwFFtxQVa1057D16ZTczBhcrxjTOz8MZXzSpYeruPl2Vqp6N8+vBUB2luSyfb+cIvfsQ2Hq39o/+7MvUIQC9snS6UGCOlf9MyVufVkAPGWfNkPObsF+Hx2v0j+GyJ2t+X+TNgXPwjVJOfnPhO9MXiTNRNQw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 12:24:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHcyBWdW2bjkWPifku6XWocvaXOWrXWpuWA
- Thread-topic: [PATCH 2/3] xen/common: llc-coloring: Fix off-by-one in parse_color_config()
Hi Michal,
> On 9 Apr 2026, at 12:39, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> The check uses >= to compare the total number of colors against
> max_num_colors (which is ARRAY_SIZE of the colors array). This
> incorrectly rejects input that would exactly fill the array.
>
> For example, with NR_LLC_COLORS=16, specifying 1 color for Xen and 15
> for dom0 would fail.
>
> Change >= to > so that exactly filling the array is permitted.
>
> Fixes: 95ef5ddf8a ("xen/arm: add Dom0 cache coloring support")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
