[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] xen/drivers/char: fix exynos4210 IRQ registration failure propagation
- To: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Thu, 9 Apr 2026 16:33:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fJUtP/iDO2spTKYHFNGBHi/9Yu5vL6tP0LS3/Jfd7sY=; b=u1LXprYVGIVwXpcJMJzRKF0TI9t3UNNhW901Hkrc0Eu4EJmATUtmtMAsbv7/Ng/avtZXcurfam1i2UfZdq0V7X1b+RAWlFCfiRNKcQpz2rkchwBeSGKXa/Goh+4V0Zw4c6m+AlrY+Gx3dwxYyFB7JaS0B+o4Ho0W0I1Ua+BKkSxwDewIUYWGAPPgc/mhzfj9bV3wm02lmcEwhPsY6L32Sk9vzgj8QHzR1r0xD2+/XuSdu2aj9vbpv4fjvpCCA1mk8qOSS66HO9O+wkKwb5qlbJn/jy2p7xRkAB7RU+zzW7CcbJe9Cp+2yEWIEMsn9D8WxMtk3BOY17eggS2CIyXtSg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uXUH92Kr4Ul+DBw/Nv7H+Snrs0sc2vfsX1/T7qetgbZqLaLwqwoMv9ngSskk/rTpXDN3Mo2R2KM/4vpAZ8dP7Qculh4kMFqOJFroDdSL36iHOZ9iDsFsDcLwHy12lyqASEV6WqpIQ4mo+XpGxhra7XoyOWb4Th2mnmTmMIboyK4wrKU7ud6a8uLXU6L9SoU6tcGhVHUZ5eQ/MDmVDh5glvV+FsywaGE/gD4o4qRKXXya6YuTbU8WlIk/vmGl/0m9G2inNV5blDP5GqlwN3sZNXKwYaYKsbF4ZZa8VO/7qqPwlJgIXuVLAR4DzWra7tjzqf+RvWo0g3kpI13vOA5vow==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 14:33:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/04/2026 15:50, Oleksii Moisieiev wrote:
> In exynos4210_uart_init_postirq(), when setup_irq() returns an error
> the failure was only logged via dprintk() and execution continued,
> unconditionally clearing UINTM and setting UMCON_INT_EN. This enabled
> receive and transmit interrupt lines with no handler registered. On
> platforms where the GIC receives these asserted lines, the result is
> either repeated spurious-interrupt warnings or an unhandled interrupt
> fault.
>
> Add an early return in the setup_irq() error branch so that the
> interrupt-enable writes to UINTM and UMCON are skipped when IRQ
> registration fails.
>
> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
