[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 4/6] arm/sysctl: Implement cpu hotplug ops
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Mykyta Poturai <Mykyta_Poturai@xxxxxxxx>
- Date: Thu, 9 Apr 2026 14:34:47 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O4HiwftaM/EHeLjeEkA86c9XaItelNEGdBAgRO06JP4=; b=QNvPksEvlZqSX9fkc8Tft6R4VFAiV/RE/cXT3+HRIj9tJx+7Vsb6e9IlHY4/4PpXj7SwELDGxZ3m5zXmAMuMcFKhZiFN2JYdzIIWD+pVi+VfjPWrtzDDVu7tzQdxe5fIp6nE2e+x8ybvEPF8Kt871exu0pr5vOrlUpZ9qWATfooJWAE1AGFxy9i+RcbWRhKzLkeZ1cHJ56+UnfAOyn/+p/kEdqdoLICXukUGygQ8+8bg/+V6R5q5uOgiqjNXF2a5UJmYMhzEr1kYyRRg3OLkL9r59thmrkI6LQ1bhNqiXq+XUkNmR7lgIlMYgCQ6ZXTx8EWFjP8JuVrSXth/NV+9hg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hMcoqb4UuOTb7ZoY+kzXKRypqYxB+J6LyGToejFBdsGxPz6vBzxF8/YgqIvSa1SL/5eJZBRc5K16XxYLogBob8D4+I4N5U6g9jA6jp/LoYk7aNk46Vt6BssmCXYleqRXbYVV5yAvhRjohduCMBSIynlyCN9PX/eMJnXYqKQT7klI8UZyr6F8n1xl+n/KMyGrwPTb9uuY8XYbGU7Q9A7ivQ8QquQQvBKHSmgnegwVzntlIVA4w1lQbSPfrij59+uEZVCub31q39xUBMOmkgSHHlrJCJi1ZoTJ62B8Pqc52FQtY+WJEe+txKjmSiUXPvHGavpNZ/0vLgnbzP6ZU/ZWFg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 09 Apr 2026 14:34:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHcwDy3jsTaF4UzaEqMI3x4mLb6EbXHAQSAgA/aiAA=
- Thread-topic: [PATCH v7 4/6] arm/sysctl: Implement cpu hotplug ops
On 3/30/26 15:28, Jan Beulich wrote:
> On 30.03.2026 13:59, Mykyta Poturai wrote:
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -638,9 +638,9 @@ config SYSTEM_SUSPEND
>> If unsure, say N.
>>
>> config CPU_HOTPLUG
>> - bool "CPU online/offline support"
>> - depends on X86
>> - default y
>> + bool "CPU online/offline support" if EXPERT || X86
>
> Why not just EXPERT?
Should it be marked as EXPERT on x86? I considered that if the option
was non configurable (always enabled), it should stay enabled by default
and always visible.
>> + depends on X86 || (ARM_64 && !HAS_ITS)
>
> The !HAS_ITS is puzzling, and it doesn't help that that option looks
> misnamed (HAS_* shouldn't have prompts imo). The description says
> something there, yes, but then also mentions FFA and TEE. Yet for
> those the option remains available.
>
HAS_ITS can be named better, but this is way out of scope for this
series, and for now this is the only way to express this dependency.
Regarding TEE and FFA, I removed them from dependencies because hotplug
may work with some TEE OS configurations, but not with all of them. That
is the main reason it is marked as EXPERT for Arm64.
>> + default y if X86
>
> Shorter as "default X86".
>
> Jan
Got it.
--
Mykyta
|
