[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/its: Decode BASER cacheability field before comparing
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Fri, 10 Apr 2026 14:30:00 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=o8aKtIfyTS7NnNaF2VcHdJIwhnf3j2RavzseU7nAs14=; fh=iJqDSrm47fKcrqsUOrnMp/75QLLg5ereb854C+E7XwE=; b=GDLRxnWy92x2Dz7BWAH9W9ipEPFs3FGIy6L1RkVHy1T9NHyYr42cFOWqUN6/WVsDGb 8C8coZbtLwzzU5yYWLxsYQameWUOjtmpFZrOwxRG+poR0GKZt/CRNTr3FXP/bpCeaavq SQKE/VrFbfGQCtb8QqZjceHGjLbPwDbzlbtvjubk1dvJ3kHaBRGgTSNoB19IjzchTBTR yKTtRwhATO/5a2knxq5AJdqc0vjz8v9maDlMqr/k7kwsX+IlCFvBWaIsWhijaSrF7yQR VYZBHEszPNoDnXNRNgigO/NA7yMumueXv2IEUwWQU0uHf0kiEUba3tRXg8/84Awfv3DK dt+Q==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1775820612; cv=none; d=google.com; s=arc-20240605; b=Vqg0adeastywaMHpoZaJGbYao6nxd4hNPFUZTsSYItNIyiga1D9NStvKNiv/vpXiSj gWiRQ/4ivS/EIn3FASrVubdEYGWh2HfTe5Hepsl8GfeghT29wpQ2oxELbS3MsJMJAPRz vn6waumH8yGnKuDnSxAsyyGSvxYPZSZk+rBmXYG3VFvAaalZ754UcfAC2QiV2qfrgfP8 zxdme+E3u6sGHiQAdUE/3W9COMJQxCEOnvHhyfWOb0efEg58CQwoS+gF0DJbkXjtwNXB YOFc/YwAh4PZF9yuLS6qQOQrC5hbwiQINg4AlTJRjdR33bJEtFvz4DLnKCuSxTunLC37 l79Q==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Mykyta Poturai <mykyta_poturai@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Apr 2026 11:30:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Apr 10, 2026 at 9:40 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 10.04.2026 08:09, Mykola Kvach wrote:
> > --- a/xen/arch/arm/gic-v3-its.c
> > +++ b/xen/arch/arm/gic-v3-its.c
> > @@ -496,7 +496,8 @@ retry:
> > }
> > attr = regc & BASER_ATTR_MASK;
> > }
> > - if ( (regc & GITS_BASER_INNER_CACHEABILITY_MASK) <= GIC_BASER_CACHE_nC
> > )
> > + if ( ((regc & GITS_BASER_INNER_CACHEABILITY_MASK) >>
> > + GITS_BASER_INNER_CACHEABILITY_SHIFT) <= GIC_BASER_CACHE_nC )
>
> Are you aware of MASK_EXTR()? This is one of the cases that we have it for.
> Really all *_SHIFT constants should be purged, as they can be calculated
> from their *_MASK counterparts (leveraging MASK_{EXTR,INSR}() to keep the
> code readable).
>
> Further, doesn't gicv3_lpi_set_proptable() have the same issue with
> GICR_PROPBASER_INNER_CACHEABILITY_MASK?
Is it acceptable to include Fixes tags for two different commits in
a single patch, or would it be better to split it? Both issues are
logically identical, just in different functions.
Best regards,
Mykola
>
> Jan
|
