[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/its: Decode BASER cacheability field before comparing
- To: Mykola Kvach <xakep.amatop@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 10 Apr 2026 12:33:46 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BwL0SmSCSGloE7YDySNcg9PHFX/+SGsk2feI05qphag=; b=Y9Sf9yq12MgzLIY2XkHZfoqv6j/C/S2fsx38hMVi7qAXfHlEZkkLFkLwEgQHbzczJWDlge/52WHMzXvpoliue3tbImMkaED+cObxNhWfhgWvaihympcnzwCk49gbcijggYV+dAKDfGxcgsyc/dzeMC6KZPNiSluGBpJtetmTHg88ph+PPn3k4kQZiDeCQip/pEyOv6EOKQ1AURUZiiQPKK8iP9mwSmxwE4WVVkULQRgKhJfnym1oabcXcYrVUU/LOE+arxKuAT5iyuW5ddZb7JvsYWBQwc27i1zo2APfG1ljX960H+AQ4RiP9ImFo9PcfSH+uThz7KHFK/+YWyP7AQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qt8jNM0LilzFOB0mYTC0iQCn8QTa9e3nQXK3bC5tvroxKY+84gklh6gn+eh35FntQn90UAsyBtmvuOPnM5eczIoUJ6jbIcIzNzkOztFtmKTjN1i2mseqAz6W5JmT2ZWnjGjJUIX7shZjNxmNUOm/3lrLPVLJj3qk1vISCIPXZUD1f9SDxSMsCYLGy3ezy5m1P9TsulFPo+ISVnSti7iAc4VI73g5ypD7EjVibb2j7x9+viWytFzxxIdxjeLh6jmmc+BqEea1jUKMGdcnmwrR7uM2NXJGvyICG91qCYzvaExkMCMZi6eAIX89CeIPYywCW1qyTfUdyTFkBrmKizVCoA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Mykyta Poturai <mykyta_poturai@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Apr 2026 11:33:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 10/04/2026 12:30 pm, Mykola Kvach wrote:
> On Fri, Apr 10, 2026 at 9:40 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 10.04.2026 08:09, Mykola Kvach wrote:
>>> --- a/xen/arch/arm/gic-v3-its.c
>>> +++ b/xen/arch/arm/gic-v3-its.c
>>> @@ -496,7 +496,8 @@ retry:
>>> }
>>> attr = regc & BASER_ATTR_MASK;
>>> }
>>> - if ( (regc & GITS_BASER_INNER_CACHEABILITY_MASK) <= GIC_BASER_CACHE_nC
>>> )
>>> + if ( ((regc & GITS_BASER_INNER_CACHEABILITY_MASK) >>
>>> + GITS_BASER_INNER_CACHEABILITY_SHIFT) <= GIC_BASER_CACHE_nC )
>> Are you aware of MASK_EXTR()? This is one of the cases that we have it for.
>> Really all *_SHIFT constants should be purged, as they can be calculated
>> from their *_MASK counterparts (leveraging MASK_{EXTR,INSR}() to keep the
>> code readable).
>>
>> Further, doesn't gicv3_lpi_set_proptable() have the same issue with
>> GICR_PROPBASER_INNER_CACHEABILITY_MASK?
> Is it acceptable to include Fixes tags for two different commits in
> a single patch, or would it be better to split it? Both issues are
> logically identical, just in different functions.
Multiple fixes tags is entirely fine, and we have several examples in
fight even now.
I'd absolutely recommend one patch with two fixes tags in this case.
~Andrew
|
