[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 04/23] xen/arm: vIOMMU: add generic vIOMMU framework


  • To: Milan Djokic <milan_djokic@xxxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Fri, 10 Apr 2026 11:39:59 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=epam.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PvDci1SFyqTJnbPBsFJG77mJZgtIVWxdMI5gGsnZR8w=; b=vVxlR7V010Cx9+PLJInheHPlCgUEkeKUPQE6xQYW6WwhjZNyVGdaDdiZbh4621huferzSPF7FhPkVTK0aYxPIyC+Ortc2WAbWwnvfqRtbtMT5rA3y7+MU251CFk5f7hTFzDMtyi+a0lZ4k8x/h+WAaT1GptORezHSeHQn7bpXTFbOBch5ion93AZ+6hmwdHXpp012GkXpxUrr2BPjhY6YLBh0u9ErU42qizbv5cp7YehLdOqohucrSLSrwgZFQZtdkaDCueRrqLtxzaUACnr2ebpNPTMOQpSZ9mWG9gDY4ST0S5buCeBGbDuQ/eMvOEYpmtFfIExySOrEBxCHupmJg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PvDci1SFyqTJnbPBsFJG77mJZgtIVWxdMI5gGsnZR8w=; b=XnrkBfHXRo1z0KQ0p5j7VZY2Sbwf+4Adg6A8JBfANsQ47UuulQ53zWE/T1peMh7mQfiuoQrZVnSrm1TIEceha1+17d9jFCXpvCGMGd++vGq9qSQRwdaP1w/TV8Qw1GkqfhJozz1iE4rwdVKt5i5j+pTY2tah64ry43e6UGljwJ9pF3Qe8Wvn3/EZL3E4mcsyz7pA2TsL4UrC3q+gup/S9Odae1j6eOlXnF4Pix4Elljy5g2dT5INXJhCHLxFfkxjedXit7owhKem2PVM2fonHayxvtRrbSwWvrAqpx2plafD+an79UfUdWZHfa/cV4SO/NshlLmSWJz1ILwpK6bKsg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=S9iVs5JHk1QMH8HQCvKSgiIlUUbhqYie5a8CMn14lD/o4z7AAjIxoHW8JWRKo3DGDZcKmNTJAS26csxEolWKp1bKsEft9andDL8K5e1pNs8ETuQnUo1OutJsr68kQrV2hZuOYdOIoJuhK811ahwFzPFvyna5X5MegVqr9ZQxOexdTtECExJwZJLx7Z6CRxFwf7MtAp/STVMKRC7yxdkOGmkouZ7tA1fQIaNzdBykFEVMBVlw7lpi5jDzdQwusSF/UYjd2/Li/x9cfRf9kA4Upf0rwosNVHBZLlo2mtXiKpAKc6CtHi+/lJHT6YGI0SaEctlSIisHF6JJAjuFJVraxA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=r2pmJP50/RFKS3CiD41VaT9xg1y72x1srwlMfQmhmXYG9dQnqCggvx0pFG36UIoxybuFaFYL878qSrupjJDvp4Po5XZB8wjx9WlQ9/yr/deSdj2GaOiBkzNbYWFSOCtl1S1yhvSbuMWCoXfEtiNW4XefUHwcvXa9ETBr/EGwckhy2OOQmhKk2FSq7IyR414TxbJp3Ccit8s7DHJ5ZwukMRJ9Wbq/8K/xjTgc3llhzavf5WE83X3aIJhy9/IOUJAtFhUBafeE4cHR1m3MRMx83//fTiw0MIs/B4ISTxYKBaIXr/EwXlidTX/1z3/dQ/oG6g2Vj9SnVTLHrnRtCWQOVQ==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=arm.com header.i="@arm.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 10 Apr 2026 11:41:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Thread-index: AQHcyN6wtGZ7ugIU+0mvCG28OqL5ew==
  • Thread-topic: [PATCH v3 04/23] xen/arm: vIOMMU: add generic vIOMMU framework

HI Milan,

apologies I missed one bit in this patch

> 
> @@ -721,6 +745,9 @@ int arch_domain_create(struct domain *d,
>     if ( (rc = sci_domain_init(d, config)) != 0 )
>         goto fail;
> 
> +    if ( (rc = domain_viommu_init(d, config->arch.viommu_type)) != 0 )
> +        goto fail;
> +

Here if this fails, we call arch_domain_destroy(), however in that function we 
don’t call
viommu_relinquish_resources()

Cheers,
Luca


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.