[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/its: Decode BASER cacheability field before comparing
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Fri, 10 Apr 2026 14:46:33 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=9q37rZP7jMWns3qTUHzx9hn/p3edhuLnNUeTWCCXISM=; fh=Npxxo2G+SZBYUBqLWTl4tfcxykh8zXXoyL5qOyJ4M6I=; b=A9rInS/Bst8AoVPEoTHDveR5sPEhsI0cguuOT+yg9G4g7ioPJzh1kxQ9niOP7V8uJ/ s3DeblrXXU8oX1UtgHTfXPP4usOepB8AUuRrQH3r5ukB5Kfi2Mv2cC6ogpENGiV5W57F gcfrgbUeKRemDp5ZYrMRDp69ybEb2r/3D6tlryUukVd/jktwIWVE8HnJgo+zt2DBYyFY Upok4fHHi75ziHF45+nFtCeJHuJGjTh/o66j8geYWi98zMxCuBuG9XxUmaRN7CBDAKOv MxJxafiBKcvFJwVpEuUjBJbr7++nN8dJF7MZScgCIPRumWfU1RilkVM4XwRBB7nLpjUI PNcQ==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1775821605; cv=none; d=google.com; s=arc-20240605; b=f8mYsxe1Lw0x1D5qUzLCwc5C5g+XXDwwLbik2+HltHu8ooft5RdWTZCLYIFp271AMv mo9taYjnUX0Em6/MsQ7odtX6rl0rpD0W0jui8I5l6kg+T8oWugQGEUD5qF0umHjGxZXl oUi9IAT4+peYYP9c7x0sbSYmhBXVg+f16rif6EUbQe6bI8lOvqdV9/xWON437JC7O0uc c2cMaLPBUj1pYrazBPvfUqTjqlBqy+x8xQH8pFzX9+Tz/9xXAhlyATeHEAmlDPGk71Jj SbWPlwiX8McnOYjsbK7lrcbHmr/JrRKruG7Jhgq+aD1uRkP0hk8S4SmlRXCQ7sBJZV+G tQxA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Mykola Kvach <mykola_kvach@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Mykyta Poturai <mykyta_poturai@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 10 Apr 2026 11:46:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Andrew,
Thank you for the review.
On Fri, Apr 10, 2026 at 2:33 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> On 10/04/2026 12:30 pm, Mykola Kvach wrote:
> > On Fri, Apr 10, 2026 at 9:40 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >> On 10.04.2026 08:09, Mykola Kvach wrote:
> >>> --- a/xen/arch/arm/gic-v3-its.c
> >>> +++ b/xen/arch/arm/gic-v3-its.c
> >>> @@ -496,7 +496,8 @@ retry:
> >>> }
> >>> attr = regc & BASER_ATTR_MASK;
> >>> }
> >>> - if ( (regc & GITS_BASER_INNER_CACHEABILITY_MASK) <=
> >>> GIC_BASER_CACHE_nC )
> >>> + if ( ((regc & GITS_BASER_INNER_CACHEABILITY_MASK) >>
> >>> + GITS_BASER_INNER_CACHEABILITY_SHIFT) <= GIC_BASER_CACHE_nC )
> >> Are you aware of MASK_EXTR()? This is one of the cases that we have it for.
> >> Really all *_SHIFT constants should be purged, as they can be calculated
> >> from their *_MASK counterparts (leveraging MASK_{EXTR,INSR}() to keep the
> >> code readable).
> >>
> >> Further, doesn't gicv3_lpi_set_proptable() have the same issue with
> >> GICR_PROPBASER_INNER_CACHEABILITY_MASK?
> > Is it acceptable to include Fixes tags for two different commits in
> > a single patch, or would it be better to split it? Both issues are
> > logically identical, just in different functions.
>
> Multiple fixes tags is entirely fine, and we have several examples in
> fight even now.
>
> I'd absolutely recommend one patch with two fixes tags in this case.
Understood, thanks.
Best regards,
Mykola
>
> ~Andrew
|
