[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v6 08/43] altp2m: Rename p2m_*_altp2m functions and move declarations out of p2m.h
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: "Spangler, Rose" <Rose.Spangler@xxxxxxxxxxxxxx>
- Date: Tue, 21 Apr 2026 14:07:09 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 40.93.13.72) smtp.rcpttodomain=amd.com smtp.mailfrom=elektrobit.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=elektrobit.com; dkim=pass (signature was verified) header.d=elektrobit.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=elektrobit.com] dkim=[1,1,header.d=elektrobit.com] dmarc=[1,1,header.from=elektrobit.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=elektrobit.com; dmarc=pass action=none header.from=elektrobit.com; dkim=pass header.d=elektrobit.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rMAbdzkmZ5IVwEOyN/4S2RtyRj/t40Q5Se0zwlSipfc=; b=GQwGxP7/W4BIBRDXWwo7DGMOL3lCAIU3DIPP8pEe7rotSn8VstbAZFzKHlY7zn/sCUCWoU2II+kh0kDOd7z5433C9gQa0dsCSh44RiDCEZkbnsrLfccG2hA7DL8dvmZlvqBG8OuLlwnv/jiPK+rjvmHwkgvLmJo21GDtS8o9VS9laxvSbYrgdbCbJFmruisGwzd1VXBO/xpqOZP11Z/S6SJkZN6oM/6AS9NL+mf2CXujOvhth+L/EH7gs/RtGzxlc7xNDs61XedDHfqIhfxDsfHX9k0Lw7NU2/vUGpQ4pxWqp+D6c3nJIFFAzm4yzgOTP85LtmO1T5xir49Or35eRw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rMAbdzkmZ5IVwEOyN/4S2RtyRj/t40Q5Se0zwlSipfc=; b=yQ6v1vi8Q8fAEhJUnJ+aT7+J8FtPlonCOy1u/2XHleh3A5u/RzlNLRlaQNHLPahWcY0nCMIWVF4Q7+xKlad16Fgvr76jdgO+c+vokKGICmGxVGP7+W+B/hT/1ij/l9nukzz07u2gITUqVZI5Opa2fDJPqYaTvQ4bTzPJAfwgAmqD4tf+MBxBLSD8dJULdRTeEM7G0R3pN/sfjjbd0W9fOMLEXzkVGXqvbhaitlymPvAYVOlSqv0HqIEpeZjsmb5bUyIm5CrHfeVl8gQ7hhFVMCtvr9J7y0HHOQtalCA9lOSRX+/fAh2jtoC00YPnnwtAinN8SdeCkRbaX3GgkvSBQw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=ohk4ZpoRy70VEe5dKDdppBaATqt8JiIrLub2bzLX5CA55aL3p3nDNGA0+il8EZfExeLx6sdYeeon/qiu3AWgfROQhm1PlxRhtgbojYkzAjTYRZCgfd66XYAxzbyIevf6LUqj72OF0EQpcuTORTq6kKEFQGQo3puDsIK9gZXmpgwvgmqZ8kKYOwgebLUkbU+oz/uMh173hq5Zc7Ky1uk7oDGVHw1aqPzUo1L7DRJu37gTh/eGYjkaCShQPfkWdZ1+VKu0eV08YhRX/M48TuzCx+GT1nGSpdLCcOOT3p5V+sBAv5j2XSk5PmYY6DxUTRbCdYBtVTLXB8dWp3OURLVJYw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Eza6aFsbNfGxfxgIflKMn1QYcVsIPU2fYEcPELTv9Lr4QUaXco2k+CAeMNBGqjRpEQcE0OI+zDr8fWa2Wb5RSxaum8xDQkNF7lwfGppo0CYUkSDsjJkfUoFxnM2rk6Yp6s3kx/6HFkTgLwv/ZwA7R4eYgA6UXuysY0eYPox4b0kBDzSz5+nKR2vSwplpdGAAwhGwPZ7kYEFcFyqK3PBZiHasXMFI3Icx0raxF80sInZZzCFc5D8m784voFAhq5bO+KM+2V/v92ybz+u9tWFxgpwVVa7SV0jDK0dVl7KRCR8YhZdxXAd46KvxhmGZWw3FEr2Dk5FpK5Jesa3bcG3ICw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=elektrobit.com header.i="@elektrobit.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"; dkim=pass header.s=selector1 header.d=elektrobit.com header.i="@elektrobit.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=elektrobit.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Tue, 21 Apr 2026 14:07:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHc0Q08g9UjbgeVPU23tPISZnL/sLXpdhuAgAAVnXI=
- Thread-topic: [RFC PATCH v6 08/43] altp2m: Rename p2m_*_altp2m functions and move declarations out of p2m.h
>The following function names could reasonably drop the _altp2m suffix:
>
>
>> - p2m_get_altp2m -> altp2m_get_altp2m
>> - p2m_set_altp2m -> altp2m_set_altp2m
>> - p2m_reset_altp2m -> altp2m_reset_altp2m
>> - p2m_activate_altp2m -> altp2m_activate_altp2m
I used these names to try to differentiate between these functions, which
operate on a single altp2m view, and the altp2m_init / altp2m_teardown /
altp2m_flush functions, which operate on all the views of a domain. For example,
without the suffix I don't think it's necessarily immediately obvious that
"altp2m_activate" or "altp2m_reset" operate on only a single view. That being
said, some of the other functions such as "altp2m_change_gfn" and
"altp2m_get_or_propagate" don't follow this convention so I could go either way
on this, I just think the suffix /could/ provide a bit more clarity for these
functions.
Best,
Rose
|
