[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v6 08/43] altp2m: Rename p2m_*_altp2m functions and move declarations out of p2m.h
- To: "Spangler, Rose" <Rose.Spangler@xxxxxxxxxxxxxx>
- From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Date: Tue, 21 Apr 2026 20:02:17 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776816177; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=zd1lEyRoFzTLgQItSNg7tNN3pcIh4yEX3S7ffIydiQA=; b=hRYDwffcaA+LuNSxSr4Lz1gvB38Iv03r6Vuzsqi1pzp3QfOh2yMm2vCerzLeuNO0iWotWZV1Ot9fu15IXPccmy/09Qxb7H14Rso/HEZui5FuQIllj0SMrIPwQRTjRYJ/GSweSCI9N9t/3H/jl6SW8UgdcorHBM43WyaRdnoKvCA=
- Arc-seal: i=1; a=rsa-sha256; t=1776816177; cv=none; d=zohomail.com; s=zohoarc; b=XYspWC+D5MzDrC+8xxyKTK8tuHjqyGEtSHIeqIbHWSZKgInkEeYQH6oNkIMvpJQOsGXoBSMtc67znWGkL5eSf+Rsj4YwvHzoUHF2fg+vBr/VL8YQb6WRFEz63FA24dD7zbmX/Rw92I6MXD/R8g5hWE0sVXZpK8JpNrdOBLetOYE=
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=zmail header.d=tklengyel.com header.i="tamas@xxxxxxxxxxxxx" header.h="MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Content-Type"
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Teddy Astie <teddy.astie@xxxxxxxxxx>
- Delivery-date: Wed, 22 Apr 2026 00:03:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
>The following function names could reasonably drop the _altp2m suffix:
>
>
>> - p2m_get_altp2m -> altp2m_get_altp2m
>> - p2m_set_altp2m -> altp2m_set_altp2m
>> - p2m_reset_altp2m -> altp2m_reset_altp2m
>> - p2m_activate_altp2m -> altp2m_activate_altp2m
I used these names to try to differentiate between these functions, which
operate on a single altp2m view, and the altp2m_init / altp2m_teardown /
altp2m_flush functions, which operate on all the views of a domain. For example,
without the suffix I don't think it's necessarily immediately obvious that
"altp2m_activate" or "altp2m_reset" operate on only a single view.
How about you add the _view suffix for these? I think it would help disambiguate them and also read better than the current _altp2m suffix ones.
Tamas
|
