[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] automation/eclair: export XEN_TARGET_ARCH during assignment
- To: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Tue, 19 May 2026 12:45:13 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1779187513; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=l+pWLWhZltNhxfkU1Tbvx1ofcBWtjiktpSBSBMEySK4=; b=5tm1fckGJ377BtVajf74/ShqvWHVRI6lMFjWVS+JLTRAqdoiGUoLanQSWOfS0jio/1rz 1q2Iq3algm6F7fvuH1Fj5Domna5sEfnk6nlAvofLCulnq+Cr4RvxWiW462ysIzcfywVva 6MzkOLT5VpH1tg7RH5ZisoBFucwQfCA76cbrxLyLmJ5RmCvffQjFYTmPhA+9yR39I/SzT ggmHAMCr7g6BU+0Y/SdvxEZicG1c0UJ0ZWE1nCPKYSMlXYlTTcarhN1gQPqDiFJypjYrO DsfieXLBGa3K3wX97tVRb+PAOfH2/aruTleU0TvvS1bmYZlQ3lQkRwFYp9eAqsruGUD7k VjJV7uiMWCw4Rujf/N2eTg7v7k0pwjKrkT8eb5lyv9Nkbgh3dckiqJp6utURtTIV3I+1q eUq9c3VpbvJRZdwZgMAG2RezC4d2BdpaFxG8DaD12a2fud/6DzW56TgnH52Q4kdEX9f53 0ZvJ8+KWEE2WBT2hwljnARXjfAOAm1V2e6mIXFhf5QDFQtNzeRC2oEiw3G5aZfzeVdMaB LeKNYljg/bWDxJXYkF0xWajN3X+C0jFtTbhrWFCConXWvbXKsZyuszHNtatJf8RIoLLhg li0ArbQtMRns8ovB+lTLmiTPOOMRRgkUlCXcOF0c9bocuii9LCRPhRDyc1B4cPM=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1779187513; b=oYPeEcgGPUgB0qDvE2MeLkxbCXzkg1BwjUB3D0E6At9TNqJt8hPnMqVbpgWsNXhyIM8u rIKP03XE6xV+o+QtOYV/l4aA5Ju+euW//KL61gzQAJpflWejGN363kR4zdTxpRGk06R03 t55sz1VG1wq9hXzUKPwaKoxJPg3aeOesaUJMtNO1NMTeMIY+pCjDaSCMZomgBDHwXiS29 NK6Zx470cgUUDNskBjBjogHeEdV34Q8vZGwi6SPXNSZVvlhGUlGCo4wGOfl6kileq4hXi 9xcCpOz3rSco9Uma6bG9CqtxTYG+Wvtt0CrtnZYi3tbExsBGBxxoQYfn93Pl8v/HUkmbd l0gydEqOMYJGYEGM6ULjJIH9Xe4dTM0fka6+WxSKgjfbZhZOLSYtSydYr1RKFqIM0xVVA NSsts9XM9kH8xLb/uwb6QrzfJ48IFs+aofXWegp8hy1E9lcT0JgTMHJ/PLGUyZxi+lpKt WQYgU6Iu26fRX87KFCeOD5KDRCukwoWZyNj9ab7uDMGiipfylXafzR64oKPIME4SeJdEo yo7FVZii5w4cHXkTvGN2oIBe+7qp/0grmH8Sny/x5TvWVrBS6pCH7/7hMuo+8ftcbipuz Gm7ZgrqRHd18DDrv587saNCimczJqz2SSsfLR8nuSA9XhEAGeL3Be1il+XNJNZ0=
- Authentication-results: eu.smtp.expurgate.cloud; none
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 19 May 2026 10:45:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2026-05-19 12:27, Dmytro Prokopchuk1 wrote:
Move XEN_TARGET_ARCH export into the architecture selection
branches instead of exporting the variable before assignment.
This ensures the selected architecture value is correctly
propagated.
Did you see a case where this is not correctly propagated? As far as I
understand, the value of XEN_TARGET_ARCH seen by subprocesses is the
last value set for the variable, regardless of where the export command
is placed.
No functional changes.
Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
---
automation/eclair_analysis/prepare.sh | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/automation/eclair_analysis/prepare.sh
b/automation/eclair_analysis/prepare.sh
index e941e6edc4..fde83c2d2d 100755
--- a/automation/eclair_analysis/prepare.sh
+++ b/automation/eclair_analysis/prepare.sh
@@ -22,12 +22,10 @@ if [ $# -ne 1 ]; then
exit 1
fi
-export XEN_TARGET_ARCH
-
if [ "$1" = "X86_64" ]; then
- XEN_TARGET_ARCH=x86_64
+ export XEN_TARGET_ARCH=x86_64
elif [ "$1" = "ARM64" ]; then
- XEN_TARGET_ARCH=arm64
+ export XEN_TARGET_ARCH=arm64
else
fatal "Unknown configuration: $1"
fi
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
