[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] automation/eclair: export XEN_TARGET_ARCH during assignment
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Tue, 19 May 2026 11:03:00 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xO4OPw0UJmY4sskhJ9357fn+X2Reta1/dye1Z+NHLck=; b=ve1JSmUFKHrVlXgZ5xE2MipUJKENm1BSG/Aby6gEsEtPTyarBeOI9fzDbvjycXwMTIESZVYa5RqQE3d1Izx76Iz9rvyJKDLdrISJLNFiYfQoNXah8HYN9992d2573APervEhUKRbIyrAGy6bZjRT0g1WEE+nPuMcbycrAOSnAWu+1CYtxpLt2LnrRD7qTy6Ujuld9fTHtbKrvKxDhlUWb2OkA4mccBhKWYViM5DewTVBYEkRhAMDeMfGBF4pQFsmjZtthaKLan4JMP+gB+krObej/xQ45XMH6fKcXpPaGxL3YBqjEdauhgKOWGMbLEa71GWqzH5Ro6FH3NRRga9I6w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yZMb/epAvqDcokPlhpo9aKZxmAl8NSWhllt5Et9+U7YeHTfIuSYq/UL+ywq0+QPrWF00VtPB6F5hbC3q4IIhClilG5cdSP/uyRWTPPoW5R4VHA5wj/m07e54C7PQiLEyAdpfEdE1zFReQmo8Tho9HOPfniyibmKQtjfCisMXikBpBd3Biv8/EX8ovUhS195l/rTy8XhAIl5TyY3rUftJji7E/lrsKmNVRhVEQAXc/QR1qcfW3XRdHvzqB478ENJq3UrV0mh54+cFExii7iEySP1xyUtSk1Fhoq3zwFsrbEfk76KqPztg3Ysdxf+jcTdbhk0md1WoGZjojKhHS40weA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=epam.com header.i="@epam.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 19 May 2026 11:03:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHc53oVx3/uBPUL1EWf6nb6ZvtStLYVKjCAgAAE+AA=
- Thread-topic: [PATCH] automation/eclair: export XEN_TARGET_ARCH during assignment
Hello Nicola,
On 5/19/26 13:45, Nicola Vetrini wrote:
> On 2026-05-19 12:27, Dmytro Prokopchuk1 wrote:
>> Move XEN_TARGET_ARCH export into the architecture selection
>> branches instead of exporting the variable before assignment.
>> This ensures the selected architecture value is correctly
>> propagated.
>>
>
> Did you see a case where this is not correctly propagated? As far as I
I didn't see a case.
> understand, the value of XEN_TARGET_ARCH seen by subprocesses is the
> last value set for the variable, regardless of where the export command
> is placed.
Yes, you are right. It works in that way.
IMO, exporting empty variable looks strange...
Anyway up to you to judge if this patch is needed or not.
BR, Dmytro.
>> No functional changes.
>>
>> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
>> ---
>> automation/eclair_analysis/prepare.sh | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/automation/eclair_analysis/prepare.sh b/automation/
>> eclair_analysis/prepare.sh
>> index e941e6edc4..fde83c2d2d 100755
>> --- a/automation/eclair_analysis/prepare.sh
>> +++ b/automation/eclair_analysis/prepare.sh
>> @@ -22,12 +22,10 @@ if [ $# -ne 1 ]; then
>> exit 1
>> fi
>>
>> -export XEN_TARGET_ARCH
>> -
>> if [ "$1" = "X86_64" ]; then
>> - XEN_TARGET_ARCH=x86_64
>> + export XEN_TARGET_ARCH=x86_64
>> elif [ "$1" = "ARM64" ]; then
>> - XEN_TARGET_ARCH=arm64
>> + export XEN_TARGET_ARCH=arm64
>> else
>> fatal "Unknown configuration: $1"
>> fi
>
|
