[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/9] livepatch-build: fix detection of structure sizes
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Tue, 19 May 2026 11:55:44 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8fOyH0DBH+exaiWsiqF3rVuVhvGeYYtelg3oQrF5zg4=; b=CptJA2Zesh2CUTLG1lntJPUHTuYJ+i3aflmT2y+yPLuK1466/qvAUD7GKkEopzs+QwGQ5dJbKF64lZRP/vADZzDpNjSJ8HJi9WpXkGfBGaci6MErjYWSfI+WdPmJBRX4IWwJr458dgP7iZDCWIvK6vnYHs8oksZlVWLEWloahbyZzVMxMkspYpDzgje6/yaqBE9osUZg/zKjrF9RwMyc3CJwCV+UH2FYEGuR6KXFgyl+OW4T2GsmRRwivyutAAjIyo+ntVljFfdJAAt15xvx/5Ln25lFKDyqB18JKCYAE5v9S7GiZGpf/KS7fi9JccAbe7AWusiExdug+xxB5IicSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pRRrWroKYDvYlcHm0ypKv4mCLKkxBPaLMG07XnCFmgS9Uz15aYDtkLLvNB7wnPiuYXIYHwAxdWc+yRxR/D5mHCnILxisHJ/qaX336tEIblP4lXOqi5EBLj5edqCjzpXL7b1r0s8DhMPdba7jcX7vWEIf05aejK2G3lic407thCwOwYvmhOE5m0phDmGv7ZcDh+EL5KnTw4QECoQtX2idipNkIDYctDrDiG77ussjcS2KFt0sY8eZzP9EjsZh+abQaIEQgA4tXTqx9CQx+yTq1Q4GUUkdN1cP3uo/ciqFV6Td7Zq9i6rt4C6Q8cPINxVTRciKNeR8l9rddEVjGZTD0Q==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Tue, 19 May 2026 10:55:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 4/29/24 3:56 PM, Roger Pau Monne wrote:
The current runes assume that in the list of DWARF tags DW_AT_byte_size will
come after DW_AT_name, but that's not always the case. On one of my builds
I've seen:
<b618> DW_AT_name : (indirect string, offset: 0x3c45):
exception_table_entry
<b61c> DW_AT_declaration : 1
<1><b61c>: Abbrev Number: 5 (DW_TAG_const_type)
<b61d> DW_AT_type : <0xb617>
<1><b621>: Abbrev Number: 14 (DW_TAG_pointer_type)
<b622> DW_AT_byte_size : 8
Instead of assuming such order, explicitly search for the DW_AT_byte_size tag
when a match in the DW_AT_name one is found.
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
Thanks
|
