[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/2] ns16550: add support for WCH CH382 serial adapters
- To: Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 2 Jun 2026 09:08:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Az2Mydg8Ou0LqfHDi3zI+N2hh0CsCH1l8vu/gmMRCtI=; b=cms5tElIvlMulMxFjzMeuurFRmJ2ibS0Q/18UX4Tp/XliSy88FYkQf7DC2Db+gr8nDyNAc6tsGLPL/+RMVxtIXAVkoK/0EjZWCdJKI7MuzLqH2kSmbh7IYMsJdfdqOfry+i2zBMOAEuNaEsF5jCm8c/oGSE6DItRLx6kQnj6wYbVcV00a9dG2iJBupyO04nT0uzEO3ACIr+9/AwMT06NJLToOhJsZFLxL8fxtuH8Lx3vzCC63FsYfbsLn35ywHe9dll0FcOKrbfLTJfU6g2z7AjZHLd0dkYhAyfJ4FHyGCkUShJJ4+WQjMIDW7l+73+YC+MuT5MDeFr1WOhUcJQttg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NBvWprghvrz6ZdsnCoEh+x9fHFuAmbtpvvZtVPSPnuYKczpq/w0TvIq5jAYd8dW4bAtNMN6UnwAuZkvlSN+h1MS9uhJAiSODwCKaR2D2WqqKlrarQ3Gaxc+JIwv7scA+eWOEwUA5uEjJGUfIZEacyeOT+tEShDAlzIa+oyTPX1WPND99CrVT19srZk1oKCtrDOrC3tFb8eM5WGK0eQ5IpJptcG+VQBSPUFp+4+R36Z1h8Ae6aBA97dqSWmQIgbMMptXwcrQCPjPw1UZCenpEmvvC2F07pjJjddvId21xBGQijcNNo3ZYy46LDMQFv5g2ty5Vtw/MWj81NAlP7mKDCg==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Denis Mukhin <dmukhin@xxxxxxxx>
- Delivery-date: Tue, 02 Jun 2026 07:08:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jun 02, 2026 at 01:34:20PM +0800, Jiaqing Zhao wrote:
> Add support for the WCH (Nanjing Qinheng Microelectronics Co., Ltd.)
> CH382 PCIe dual port serial adapter. The CH382 is available in two
> variants:
> - CH382 2S [1c00:3253]: 2 serial ports
> - CH382 2S1P [1c00:3250]: 2 serial ports + 1 parallel port
>
> This chip uses IO BAR0, base baud rate 115200, ports starting at offset
> 0xc0 and spaced 8 bytes apart, and a 256-byte FIFO. [1]
>
> [1] https://www.wch-ic.com/downloads/CH382DS1_PDF.html
>
> Signed-off-by: Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx>
> Reviewed-by: Denis Mukhin <dmukhin@xxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
> xen/drivers/char/ns16550.c | 23 +++++++++++++++++++++++
> xen/include/xen/pci_ids.h | 2 ++
> 2 files changed, 25 insertions(+)
>
> diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
> index 878da27f2e..cf10a06a3d 100644
> --- a/xen/drivers/char/ns16550.c
> +++ b/xen/drivers/char/ns16550.c
> @@ -95,6 +95,7 @@ struct ns16550_config {
> param_exar_xr17v354,
> param_exar_xr17v358,
> param_intel_lpss,
> + param_wch_ch382,
> } param;
> };
>
> @@ -861,6 +862,16 @@ static const struct ns16550_config_param __initconst
> uart_param[] = {
> .mmio = 1,
> .max_ports = 1,
> },
> + [param_wch_ch382] = {
> + .base_baud = 115200,
> + .first_offset = 0xc0,
> + .uart_offset = 8,
> + .reg_width = 1,
> + .fifo_size = 256,
> + .lsr_mask = UART_LSR_THRE,
> + .bar0 = 1,
.bar0 field is a boolean, and hence this should be "true", not "1".
The rest LGTM:
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
