Xen project Mailing List

[PATCH v5 1/3] ns16550: properly initialize booleans in uart_param[]

From: Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx>

Date: Wed, 3 Jun 2026 00:13:20 +0800

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/5wjExFgrECeZXo0LIdaPSLBa1YW2XcC2RuGP6B0jas=; b=pkjSGwVkDZ/R5fwkNfI33BwxtC92RvhKI/YdB1ps8ufM9Fdx+81Xrh0iLhOFiPlRwGB5QbDar2CG6/Cve3MWHAWLj/UXcpgkB1hf7RwPZnRRRgZvCceAZ6b5K9xYNoniMmrEWbB5JM2aVYqNtmfpRTTMdH2M7jG492qv5uDqdWnVqphh2dv+ghO+iyNNmO9gt1Oqnsr6kT5+E4Q5kNcyDIhpnh72bzQCnIXzmb2q9mua0bCqDin9TWUMoQMSUMGVFxHh079wDc9e0FEAQ1tejM60iL3HOq0aRi3aAvKO9kTNxj14CFgmc7YRxMCPGzw/yBi39Mid0tTv/n7e5v0TOQ==

Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CEC+S1LnzucJm+jsTMOqmzS4bH6by/5g4MttIT7+sFD0R/3ZBOH4ljU7BtJxWseCB/R8BvoJNDrO1xBg2J9X7aqo12WFlRsUrPoeTTCn72kx3S6ZQblKcKIj5CkMdm45nvXHXw50OY9KQtCi16KhKqLOYrwyZOfXIMjaEsYuI8901gnXOPXEwp+Ba79D/9Ag8YO4dn2z8rc4QEG/szsZKat+6h2AtuhO5/oTteWo7Z3N2TGqgTaSV0l9ZiH9QUqMRecta5svXKQyJ2MMU1NYtYwBy71Q270BlqdCVYy/Cf5bERSDo0lyDKcu1nC3+VEEjs2xU9/lNlcRbV38xvuycg==

Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=amd.com header.i="@amd.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck"

Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx>

Delivery-date: Tue, 02 Jun 2026 16:14:01 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

.bar0 and .mmio in struct ns16550_config_param are booleans, hence they should be initialized with "true", not "1". No functional change. Signed-off-by: Jiaqing Zhao <Zhao.Jiaqing@xxxxxxx> --- xen/drivers/char/ns16550.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index 878da27f2e..ed4e29ec25 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -758,7 +758,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = (UART_LSR_THRE | UART_LSR_TEMT), - .mmio = 1, + .mmio = true, .max_ports = 1, }, [param_oxford] = { @@ -768,7 +768,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .mmio = 1, + .mmio = true, .max_ports = 1, /* It can do more, but we would need more custom code.*/ }, [param_oxford_2port] = { @@ -778,7 +778,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .mmio = 1, + .mmio = true, .max_ports = 2, }, [param_pericom_1port] = { @@ -787,7 +787,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 1, }, [param_pericom_2port] = { @@ -796,7 +796,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 2, }, /* @@ -809,7 +809,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 4, }, [param_pericom_8port] = { @@ -818,7 +818,7 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 16, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, + .bar0 = true, .max_ports = 8, }, [param_exar_xr17v352] = { @@ -827,8 +827,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 256, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 2, }, [param_exar_xr17v354] = { @@ -837,8 +837,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 256, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 4, }, [param_exar_xr17v358] = { @@ -847,8 +847,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 256, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 8, }, [param_intel_lpss] = { @@ -857,8 +857,8 @@ static const struct ns16550_config_param __initconst uart_param[] = { .reg_width = 1, .fifo_size = 64, .lsr_mask = UART_LSR_THRE, - .bar0 = 1, - .mmio = 1, + .bar0 = true, + .mmio = true, .max_ports = 1, }, }; -- 2.53.0

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.