[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.22?] xen/arm: mask debug exceptions in initial AArch64 guest state
- To: Julien Grall <julien@xxxxxxx>
- From: Mykola Kvach <xakep.amatop@xxxxxxxxx>
- Date: Sun, 21 Jun 2026 17:30:37 +0300
- Arc-authentication-results: i=1; mx.google.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=+KC0u/KRYobJp2JZVAxFOAwL39TOvhEZsL8jNRWiAuM=; fh=c26W8yzhfrIIIAjqZnhAjFtxMz7x1oQjE+CBX55p50c=; b=TUByrexCTahNEru31xQKc3OO8V7HYw6fYHdHS9bq2bSjyz9+82MUm5idPFJvFmvmrq P2AywxyKdbBD0iuS19cjN/W4OJYoN0Di7lCvYLU4tCkB5sZKHD3rtJHX/vwtZV/WvEeI li8wi4pb2h8tN9zzcPxv0DTQNr3L2n5CDBBK0Z+f0aK3Yu3//nMVbVcpx856V2QtuJsN /InHiE9hDNStWjXUA0gc5QKZ5F2Eq/B4qgvW+/rfHJjMMvSL3+d4htoaVNJz1Ok7jLff hnVoAuJLc8iwbz3oRNIL6U/3rCUX2jbnRTheI4Q+iCGzwiCCvuHmAgtOn15KqARa3u0f U50A==; darn=lists.xenproject.org
- Arc-seal: i=1; a=rsa-sha256; t=1782052249; cv=none; d=google.com; s=arc-20240605; b=hPRu9Sq6ULFaq/nYC6c5WnLpH+4FIUAT6BfEvVWfR7VuzIO+zwWbd1yCmT5XklsWY4 tmAeBX3EWFsxuLcL5NjP4VfY9aZQVOycdF/xbmBQk/R6phjoCx4a7bTPClwJ2Og0Quh4 xIdtSDe6RXZNL9ZnMOiqovtSCBVPAk505g+VlF9rqBl2FYBMF8B5B8OU+5uO4DIvpqlM vYIjgbf0AciOBSrFAXxo+HNszwfphZ6y12mD/qLEsZ92UnRi3faH50/ruS7+BtzZ1dCo 22ATDCXTHUvsqOhqp3Kz8Lv6QzJ4+bzIInEzpTGpKC51/07vcuQJDAO2O8zKHlGhb5QL 5WkA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=20251104 header.d=gmail.com header.i="@gmail.com" header.h="Content-Transfer-Encoding:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References:MIME-Version"
- Cc: Mykola Kvach <mykola_kvach@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Delivery-date: Sun, 21 Jun 2026 14:31:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
Thanks for the review.
On Sat, Jun 20, 2026 at 12:07 AM Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Mykola,
>
> On 19/06/2026 19:37, Mykola Kvach wrote:
> > PSR_GUEST64_INIT currently masks SError, IRQ and FIQ, but leaves debug
> > exceptions unmasked. Both the AArch64 Linux boot protocol and PSCI entry
> > requirements expect PSTATE.DAIF to be masked.
> >
> > Add PSR_DBG_MASK to PSR_GUEST64_INIT. This fixes the initial AArch64 guest
> > entry state as well as virtual PSCI CPU_ON and SYSTEM_SUSPEND resume entry.
> >
> > Signed-off-by: Mykola Kvach <mykola_kvach@xxxxxxxx>
>
> Reviewed-by: Julien Grall <julien@xxxxxxx>
>
> Regarding Xen 4.22, I understand and agree this is technically against
> the specification. However, AFAIR, we don't expose debug registers to
> the guest. So there should be no impact.
>
> The slight risk with this patch is OS that may have started to rely on
> Xen behavior (hopefully not here, but I know we had a couple of cases
> with the timer for instance...).
>
> This has been present forever. So unless there is a real issue, I am
> tempted to suggest to wait until the release is out and backport after.
>
> I will leave Oleksii the final decision.
I agree with your assessment. I am fine with deferring this until after the
release unless Oleksii decides otherwise.
The patch is not fixing any known issue and was only intended to align the
guest entry state with the documented requirements.
Best regards,
Mykola
|
