[Xen-devel] Re: [Xen-users] Xen-3.4-testing build failure

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

On Wed, Jan 06, 2010 at 10:23:04PM -0800, Kashmira. K. wrote:
> Hello Xen users
> 
> I am trying to do a Xen cable linux build and am seeing a build failures.
> 
> I did 
>     - hg clone http://xenbits.xensource.com/xen-3.4-testing.hg 
>     - cd xen-3.4-testing
>     - make world
> 
> During the  "make world" I see the following compile error. 
>   LD      drivers/xen/pcifront/built-in.o
>   CC      drivers/xen/privcmd/privcmd.o
> /root/work/xen-3.4-testing.hg/linux-2.6.18-xen.hg/drivers/xen/privcmd/privcmd.c:
>  37: error: expected declaration
specifiers or Ãâ??...Ãâ??? before Ãâ??pgtable_tÃâ???
> /root/work/xen-3.4-testing.hg/linux-2.6.18-xen.hg/drivers/xen/privcmd/privcmd.c:
>   In function
Ãâ??enforce_singleshot_mappingÃâ???:
> /root/work/xen-3.4-testing.hg/linux-2.6.18-xen.hg/drivers/xen/privcmd/privcmd.c:
>  48: warning: passing argument 4 of
Ãâ??apply_to_page_rangeÃâ??? from incompatible point er type
> make[9]: *** [drivers/xen/privcmd/privcmd.o] Error 1
> make[8]: *** [drivers/xen/privcmd] Error 2
> make[7]: *** [drivers/xen] Error 2
> make[6]: *** [drivers] Error 2
> make[5]: *** [vmlinuz] Error 2
> make[4]: *** [vmlinuz] Error 2
> 
> Any pointer on how to fix this.

Patch below - pgtable_t apparently didn't exist in 2.6.18 yet.

Jan

Subject: privcmd: fix build

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- head-2010-01-04.orig/drivers/xen/privcmd/privcmd.c  2010-01-04 
13:32:08.000000000 +0100
+++ head-2010-01-04/drivers/xen/privcmd/privcmd.c       2010-01-05 
11:21:42.000000000 +0100
@@ -34,7 +34,7 @@ static struct proc_dir_entry *capabiliti
 static struct proc_dir_entry *capabilities_intf;
 
 #ifndef HAVE_ARCH_PRIVCMD_MMAP
-static int enforce_singleshot_mapping_fn(pte_t *pte, pgtable_t token,
+static int enforce_singleshot_mapping_fn(pte_t *pte, struct page *pmd_page,
                                         unsigned long addr, void *data)
 {
        return pte_none(*pte) ? 0 : -EBUSY;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel