Re: [Xen-users] build xen from source on 4.6.1 in Stretch, qemu-xen error

[Mark Pryor <tlviewer@xxxxxxxxx>]

The patch that introduced the xfsctl feature is from 2010

https://lists.nongnu.org/archive/html/qemu-devel/2010-12/msg00951.html

Sorry for pasting the wrong link above.

The conflict between linux/fs.h & xfs/xfs.h is unique to Debian Stretch/Sid. No other distro I know of has changed linux/fs.h by adding parts of the xfs headers. Upstream qemu still has the xfsctl feature from the 2010 patch.

Lately, when building Xen/Qemu-xen for Stretch, I copy the old linux/fs.h (8.37kB) into the qemu-xen include folder before starting `make dist`

starting with the old fs.h in the Xen root:

mkdir -p tools/qemu-xen/include/linux

cp -p fs.h tools/qemu-xen/include/linux

this way the header is used only by the qemu build and I don't foul the Debian packaging.

PryMar56

On Friday, April 22, 2016 2:02 AM, Roger Pau Monné <roger.pau@xxxxxxxxxx> wrote:

On Sat, Apr 16, 2016 at 11:07:14PM +0000, Mark Pryor wrote:

> ---------------- build error ----------
> In file included from /usr/include/xfs/xfs.h:58:0,
>                  from /home/tlviewer/xen-4.6.1/tools/qemu-xen/block/raw-posix.c:90:
> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
>  struct fsxattr {
>        ^
> In file included from /home/tlviewer/xen-4.6.1/tools/qemu-xen/block/raw-posix.c:58:0:
> /usr/include/linux/fs.h:155:8: note: originally defined here
>  struct fsxattr {
>        ^
> make[3]: *** [block/raw-posix.o] Error 1
> make[2]: *** [subdir-all-qemu-xen-dir] Error 2
> make[1]: *** [subdirs-install] Error 2
> make: *** [install-tools] Error 2
> -------------- end error -----------
>
> The same build in Xenial works, so comparing
> /usr/include/linux/fs.h
>
> on both its seen that Xenial version is smaller (Apr 9), and Stretch has a larger version (Apr 14).
>
> The Stretch version of /usr/include/linux/fs.h now has the same structs as xfs.h, so we get the redefinition errors.
>
> I saw no patch of the Xen tools tree to fix this, so I searched the qemu-xen configure for a switch.
>
> https://lists.gnu.org/archive/html/grub-devel/2016-03/msg00071.html
> turned up this flag: --disable-xfsctl
> --with-extra-qemuu-configure-args="--disable-werror --disable-xfsctl"

Thanks for the report. Do you know if this is fixed in newer versions of
QEMU? (and if there's a patch we can backport to our qemu-xen tree in order
to also fix it?)

Roger.

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxx
http://lists.xen.org/xen-users