Re: [MirageOS-devel] NTP client integration with MirageOS / Mini-OS

[Mindy <mindy@xxxxxxxxxxxxxxxxxxx>]

On 07/27/2016 02:05 PM, Matthew Gray wrote:

On Wed, Jul 20, 2016 at 6:31 PM, Thomas Leonard <talex5@xxxxxxxxx> wrote:

The CLOCK signature uses

  val time: unit -> float

rather than

  val time: t -> float

for some reason, which makes this difficult. I suggest changing the
signature to work like the other devices.

I agree, it would make an NTP-corrected clock using Kia's work much easier, and I think it will also simplify writing fake / test clocks.

I worked on this a little bit and added a PCLOCK.t and DEVICE signature to PCLOCK

see

https://github.com/mattgray/mirage/commit/5b83035c1dcfc7e5aec8e7d9fc46f96f8e57ffc7

https://github.com/mattgray/mirage-clock/commit/b9b225e64b6ff7e9a714d13af65803ea6845a055

It compiles and does the right thing (ie. nothing in connect and disconnect) but I'm pretty confused around V1_LWT and implementing the DEVICE signature correctly, so some review / help there would be appreciated.

Should MCLOCK also implement the DEVICE signature? I think so, for consistency.

Making PCLOCK be a device looks completely reasonable to me, and I see no reason not to make MCLOCK be one as well.  Thoughts?

_______________________________________________
MirageOS-devel mailing list
MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/mirageos-devel