Re: [Xen-devel] [patch] Lets not put statements with side-effects inside BUG_ON()

[Muli Ben-Yehuda <mulix@xxxxxxxxx>]

On Thu, Oct 27, 2005 at 12:29:12PM +0200, Arjan van de Ven wrote:

> BUG_ON() is a macro very very similar to assert(), and it's a really bad
> idea in general to put statements with side-effects inside such a construct
> (for example the BUG_ON() could be compiled away for non-debug builds).
> 
> The patch below fixes this for the drivers/xen tree.

I'd like to see this applied, to both Xen and the vanilla kernel;
however, it should be noted that no version of Linux or Xen compiles
BUG_ON() away without evaluating its arguments.

Cheers,
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel