[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [1/4] [NET] back: Fix maximum fragment check

On Fri, Jun 30, 2006 at 03:36:49PM +0100, Keir Fraser wrote:
> I'm not too bothered either way, but I personally prefer having the 
> more properly qualified names listed under feature-gso. Pulling it 
> apart with strstr() in netfront (for each proto that netfront can deal 
> with) wouldn't be hard.

I can call it feature-gso-tcpv4, feature-gso-udpv4, etc.

> Do we then need the 'type' at all? What is it actually used for -- I'd 
> assume the network stack would demux to the correct protocol code as it 
> would for any ordinary packet, so why does it need help with the 
> protocol for GSO packets?

Good point.  I'll get rid of it.

Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.