[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [1/4] [NET] back: Fix maximum fragment check

On Sat, Jul 01, 2006 at 01:26:09PM +1000, herbert wrote:
> > Do we then need the 'type' at all? What is it actually used for -- I'd 
> > assume the network stack would demux to the correct protocol code as it 
> > would for any ordinary packet, so why does it need help with the 
> > protocol for GSO packets?
> Good point.  I'll get rid of it.

Actually, we do need it for two reasons:

1. To indicate protocol for drivers that can cope with malformed packets.
   The header verification will be skipped for such drivers.
2. To carry extra flags such as ECN that cannot harm the host if set

Given that Linux will cope with malformed headers or a bogus gso_type, I'd
really like to keep the type value uniform between Linux and Xen.

Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.