Re: [Xen-devel] [PATCH] libxenstore should be executable

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>]

On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote:
> Shared libraries are supposed to be installed +x
> 
> Signed-off-by: Jeremy Katz <katzj@xxxxxxxxxx>
> 
> Jeremy

> diff -r fd6d12935b56 tools/xenstore/Makefile
> --- a/tools/xenstore/Makefile Mon Jul 03 16:07:20 2006 +0100
> +++ b/tools/xenstore/Makefile Mon Jul 03 23:26:44 2006 -0400
> @@ -171,7 +171,7 @@ install: all
>       $(INSTALL_PROG) xenstore-control $(DESTDIR)/usr/bin
>       $(INSTALL_PROG) xenstore-ls $(DESTDIR)/usr/bin
>       $(INSTALL_DIR) -p $(DESTDIR)/usr/$(LIBDIR)
> -     $(INSTALL_DATA) libxenstore.so $(DESTDIR)/usr/$(LIBDIR)
> +     $(INSTALL_PROG) libxenstore.so $(DESTDIR)/usr/$(LIBDIR)
>       $(INSTALL_DATA) xs.h $(DESTDIR)/usr/include
>       $(INSTALL_DATA) xs_lib.h $(DESTDIR)/usr/include

I don't think that needed (almost all libraries in my /usr/lib are -x).
Even then you shouldn't call INSTALL_**PROG** but just create an
INSTALL_LIB or somethign similar..

-- 
Vincent Hanquez

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel