[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [RFC PATCH 15/33] move segment checks to subarch

On Tue, 2006-07-18 at 00:00 -0700, Chris Wright wrote:
> plain text document attachment (i386-segments)
> We allow for the fact that the guest kernel may not run in ring 0.
> This requires some abstraction in a few places when setting %cs or
> checking privilege level (user vs kernel).

> -     regs.xcs = __KERNEL_CS;
> +     regs.xcs = get_kernel_cs();


wouldn't this patch be simpler if __KERNEL_CS just became the macro that
currently is get_kernel_cs() for the XEN case? then code like this
doesn't need changing at all...

   Arjan van de Ven

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.