[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [5/11] [NET] back: Replace netif->active with netif_carrier_ok

On Thu, Jul 27, 2006 at 02:11:01PM +0100, Keir Fraser wrote:
> netif->active is also conditional on whether or not the interface is 
> open ('running'). So it's not as good a fit for netif_carrier as the 
> status field you similarly replaced in netfront.
> Perhaps you could replace the netback status field 
> (CONNECTED/DISCONNECTED) instead? I think the extra value DISCONNECTING 
> is not really necessary any more, so it should map onto the boolean 
> netif_carrier okay.
> Then ->active could also potentially be removed. It would correspond to 
> netif_running&&netif_carrier_ok.

Good point.  I've made the carrier correspond to CONNECTED/DISCONNECTED
and added the netif_running tests.

Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.