Re: [Xen-devel] xen-hotplug.patch

[Emmanuel Ackaouy <ack@xxxxxxxxxxxxx>]

On Wed, Aug 02, 2006 at 03:02:51PM +0100, Jan Beulich wrote:
> Could someone point out the relevance of that patch (in 
> patches/linux-2.6.16.13/). For my eyes it looks just wrong, as
> it reverts the general effort of not touching per-CPU data of offline CPUs.

Yeah it's an argueable hack but it does make things nicer when
you hotplug CPUs in and out of guests.

Here's the changeset description:

------------------------------------------------------------
# HG changeset patch
# User ack@xxxxxxxxxxxxxxxxxxxxxxx
# Node ID c6da0c5b03ffec5ce4130aeba90a49f218772622
# Parent  dec7f819293c11f88281aa0fe408a10f8c1345ce
Patch linux so that /proc/stat shows all -- not just online -- CPUs.
This way, tools such as TOP don't freak out when CPUs are hotplugged.
------------------------------------------------------------

Without this, top crashes when you hotplug CPUs out and it
just doesn't notice new CPUs coming online.

I'm all for a better fix if we can come up with one. Aside
from changing tons of libs and apps to deal with the reality
of CPUs coming online and going offline dynamically, I'm not
sure what we can do though.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel