Re: [Patch][RFC] Support "xm dump" (is Re: [Xen-devel] Re: [Patch] Enable "sysrq c" handler for domU coredump)

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, Horms

Thank you for your comments.
This is very helpful.

>> diff -r 10b05c2e7947 -r a16cc49dbd01 tools/libxc/xenctrl.h
>> --- a/tools/libxc/xenctrl.h  Tue Aug 01 18:08:01 2006 +0100
>> +++ b/tools/libxc/xenctrl.h  Thu Aug 03 09:20:16 2006 +0900
>> @@ -202,6 +202,17 @@ int xc_domain_unpause(int xc_handle,
>>                        uint32_t domid);
>>  
>>  /**
>> + * This function dump a domain. A domain_dump only crash domain.
>> + * after crash domain, xc_domain_dumpcore dump domain memory.
>
>Perhaps:
>
>  /**
>   * This function dumps a domain to a core file. It does this by
>   * crashing the domain, after which xc_domain_dumpcore() will dump the
>   * domain's memory.
>
Yes, you are right.
Your comments is very clear.
I use your comments. :)

>> @@ -945,6 +950,13 @@ static PyMethodDef pyxc_methods[] = {
>>        "Dump core of a domain.\n"
>>        " dom [int]: Identifier of domain to dump core of.\n"
>>        " corefile [string]: Name of corefile to be created.\n\n"
>> +      "Returns: [int] 0 on success; -1 on error.\n" },
>> +
>> +    { "domain_dump", 
>> +      (PyCFunction)pyxc_domain_dump, 
>> +      METH_VARARGS, "\n"
>> +      "Dump of a domain.\n"
>
>The description sof domain_dumpcore vs domain_dump above
>are somewhat ambigious. Could you make it clearer what
>the difference between the two is?
>
>Perhaps:
>         "Crash a domain so that it will dump core\n"
>
Yes, this is also good.

Best Regards,

Akio Takebe


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel