Re: [Xen-devel] [PATCH] Porting Mini-OS to ia64

[Grzegorz Milos <gm281@xxxxxxxxx>]

Dear Dietmar

Yes, I'm Mini-OS maintainer. It's great that somebody wants to port  
it to IA64.
With respect to your patch. I would prefer to see the following  
directory structure:
mini-os/include/x86
mini-os/include/x86/x86_32
mini-os/include/x86/x86_64
If we find that there is only one file in x86_32/x86_64 it would be  
better to scrap the two directories and put the files in x86.
Continuing, architecture dependent .c files should end up in:
mini-os/arch/x86
mini-os/arch/x86/x86_32
mini-os/arch/x86/x86_64

The above is consistant with the directory structure in xen itself.

I have also noticed that you left some debug statements in your  
version of Makefile. Obviously we will not commit these to the public  
repository. So if you remove them before dumping the diff it would  
make my life little easier.
Finally, when you moved the files around, have you used: hg mv, or  
just mv. The first one is better :).
Cheers
Gregor

On 1 Aug 2006, at 07:28, Dietmar Hahn wrote:

> Hi,
>
> last week I send a mail asking for some small re-architectures of  
> mini-os for
> porting to ia64. Unfortunately I didn't get an answer so I try it  
> again with a
> first draft. I tried the changes as small as possible. Currently I  
> did  only
> adding some new directories and moving some files.
> I created:
> mini-os/include/x86
>     It's for common header files for x86_32 and x86_64, currently  
> os.h and
>     spinlock.h .
> mini-os/include/x86_32
>     It's for special x86_32 header files, currently hypercall- 
> x86_32.h.
> mini-os/include/x86_64
>     It's for special x86_64 header files, currently hypercall- 
> x86_64.h.
> mini-os/x86
>     For common code files for x86_32 and x86_64, currently traps.c
>
> I changed mini-os/Makefile to support the new structure.
> Please can anybody look at this and give some feedback.
> Thanks.
>
> Dietmar.
> <mini-os.diff>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel