Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64

[Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxxxxxxx>]

Hi Grzegorz ,

Am Donnerstag, 3. August 2006 12:30 schrieb Grzegorz Milos:
> Dear Dietmar
>
> Yes, I'm Mini-OS maintainer. It's great that somebody wants to port
> it to IA64.
>
Nice to hear.

> With respect to your patch. I would prefer to see the following
> directory structure:
> mini-os/include/x86
> mini-os/include/x86/x86_32
> mini-os/include/x86/x86_64
> If we find that there is only one file in x86_32/x86_64 it would be
> better to scrap the two directories and put the files in x86.
>
> Continuing, architecture dependent .c files should end up in:
> mini-os/arch/x86
> mini-os/arch/x86/x86_32
> mini-os/arch/x86/x86_64
>
> The above is consistant with the directory structure in xen itself.
Yes you are right!

>
> I have also noticed that you left some debug statements in your
> version of Makefile. Obviously we will not commit these to the public
> repository. So if you remove them before dumping the diff it would
> make my life little easier.
>
Sorry, I saw this short time after sending the patch - now it's fixed;-).

> Finally, when you moved the files around, have you used: hg mv, or
> just mv. The first one is better :).
>
Yes I did 'hg rename'.

> Cheers
> Gregor
>

I moved only few files and changed the Makefile. In the next step I will look 
into the files for special defines for x86_32 and x86_64.
I hope this patch is ok now.
Thanks.

Dietmar.

Attachment: mini-os.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel