Re: [Xen-devel] [PATCH][LINUX] use machine_emergency_restart() from the generic header.

[Jimi Xenidis <jimix@xxxxxxxxxxxxxx>]

First, I apologize for not seeing the link error.

On Aug 8, 2006, at 4:46 AM, Keir Fraser wrote:
> On 7/8/06 6:20 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:
>
> > This patch uses the standard generic header for the definition of
> > machine_emergency_restart() and reverses the call path for XenoLinux.
> It doesn't reverse the call path, it removes  
> machine_emergency_restart()
> entirely from drivers/xen/core/reboot.c. Hence the kernel no longer  
> builds.
File:
  include/asm-generic/emergency-restart.h
Defines:
  static inline void machine_emergency_restart(void)
  {
        machine_restart(NULL);
  }

But asm-i386 has a def that is not the same.
If fact all arch's accept for i386 and x86_64 define it like:

  #ifndef _ASM_EMERGENCY_RESTART_H
  #define _ASM_EMERGENCY_RESTART_H

  #include <asm-generic/emergency-restart.h>

  #endif /* _ASM_EMERGENCY_RESTART_H */

> What is wrong with the code as it is? It follows the call order of the
> arch-specific reboot.c (e.g., arch/i386/kernel/reboot.c).
I have a linker problem building this file in POWERPC as you may  
suspect.
The ./driver/xen/ file is more like the other archs than x86, and  
should be more portable.
Not sure what header magik would be needed here, if you think its  
worthwhile I'll pursue it.
-JX







_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel