Re: [Xen-devel] [PATCH][RESEND] Porting Mini-OS to ia64

[Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxxxxxxx>]

Am Montag, 7. August 2006 14:50 schrieb Grzegorz Milos:
> >> With respect to your patch. I would prefer to see the following
> >> directory structure:
> >> mini-os/include/x86
> >> mini-os/include/x86/x86_32
> >> mini-os/include/x86/x86_64
> >> If we find that there is only one file in x86_32/x86_64 it would be
> >> better to scrap the two directories and put the files in x86.
> >>
> >> Continuing, architecture dependent .c files should end up in:
> >> mini-os/arch/x86
> >> mini-os/arch/x86/x86_32
> >> mini-os/arch/x86/x86_64
> >
> > I moved only few files and changed the Makefile. In the next step I will
> > look into the files for special defines for x86_32 and x86_64.
> > I hope this patch is ok now.
>
> The patch still introduces
> mini-os/include/x86_32 and mini-os/include/x86_64.
Sorry I overlooked the right directory hierarchy.

>
> I would prefer both x86_32 and x86_64 to be subdirectories of
> mini-os/include/x86.
I hope, now it's correct!

>
> Also, I would replace "=" with "+=" when you assign to EXTRA_INC/SRC in
> mini-os/Makefile.
OK I did this.
I also added some lines for creating architecture dependent links.
Maybe there are some discussion points about the rules I added.

>
> Cheers
> Gregor
>
Thanks for understanding.

Dietmar.

Attachment: mini-os.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel