Re: [Xen-devel] [PATCH][XEN]xm dump command add on

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Tue, Aug 15, 2006 at 08:49:57AM +0900, Ken Hironaka wrote:

> > Better as "Domain core dump requested for domain %s (%d)" ?
> > 
> I must note, this section is in C code and not Python, as it is part of
> xc_dumpcore() in libxc. I understand that it is better to log the error
> as soon as possible, but logging takes place at the Python layer above.

Not sure why that's relevant? I was merely asking for better text for
the message.

> > > +    if not live:
> > > +        print "pausing domain:%s ..." % str(dom)
> > > +        server.xend.domain.pause(dom)
> > 
> > Is it really worth mentioning the pause? It doesn't take any amount of
> > time, surely.
> Yes, I do think that is is necessary to mention a pause. There are times
> when the user will send an Interrupt with say, CTRL+C at the middle of
> dumping. Of course, xm dump will terminate, but the domU will continue

Perhaps that's a bug - it should clean up on a control-C by unpausing
the domain, if appropriate.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel