[Xen-devel] Re: [POWERPC/IA64] Updates required due to loader changes

[Horms <horms@xxxxxxxxxxxx>]

On Fri, Aug 25, 2006 at 10:42:25AM +0100, Ian Campbell wrote:
> On Fri, 2006-08-25 at 12:21 +0900, Horms wrote:
> > On Thu, 24 Aug 2006 15:29:48 -0500, Hollis Blanchard wrote:
> > > On Thu, 2006-08-24 at 14:16 -0600, Alex Williamson wrote:
> > >> 
> > >> diff -r d5eb5205ff35 tools/xcutils/readnotes.c
> > >> --- a/tools/xcutils/readnotes.c       Thu Aug 24 16:25:49 2006 +0100
> > >> +++ b/tools/xcutils/readnotes.c       Thu Aug 24 14:12:45 2006 -0600
> > >> @@ -22,7 +22,7 @@ typedef Elf32_Nhdr Elf_Nhdr;
> > >>  typedef Elf32_Nhdr Elf_Nhdr;
> > >>  typedef Elf32_Half Elf_Half;
> > >>  typedef Elf32_Word Elf_Word;
> > >> -#elif defined(__x86_64__)
> > >> +#elif defined(__x86_64__) || defined(__ia64__)
> > >>  typedef Elf64_Ehdr Elf_Ehdr;
> > >>  typedef Elf64_Nhdr Elf_Nhdr;
> > >>  typedef Elf64_Half Elf_Half;
> > > 
> > > Are we doing this again? Ian, please use ELFSIZE, as seen in the
> > > following files:
> > >        tools/libxc/xg_private.h
> > >        tools/libxc/xc_elf.h
> > >        tools/libxc/xc_load_elf.c
> > >        config/powerpc64.mk
> > > 
> > 
> > Is the patch below what you had in mind?
> 
> Nearly, we need to define ELFSIZE if it isn't already since not all
> architectures define it.

I was wondering about that. Perhaps the defination you propose
could be moved somewhere central, like elf.h.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel