Re: [Xen-devel] Error in XendCheckpoint: failed to flush file

[Keir Fraser <keir@xxxxxxxxxxxxx>]

On 28/2/07 16:15, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

> Note that I thought about plumbing the live flag through to
> xc_linux_restore as is done with xc_linux_save but decided I didn't want
> to change the API... therefore I changed xc_linux_restore to figure out
> if the fd is a socket or not... hopefully this works on Solaris??? (just
> testing now).

Use of the live flag to gate the flush/sync calls is not a good idea. We can
'live save' to disc (checkpointing) and we can 'non-live migrate' via a
socket. So the live flag is not really an indicator of what the file
descriptor maps to (file vs. socket). Best to unconditionally try the
flush/sync and ignore errors.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel