[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [Xen-devel] Error in XendCheckpoint: failed to flush file

  • To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, "Stefan Berger" <stefanb@xxxxxxxxxx>, "xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>
  • Date: Wed, 28 Feb 2007 13:07:25 -0500
  • Delivery-date: Wed, 28 Feb 2007 10:06:45 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcdbBqwu6tNHM8b5Edu40AAWy6hiGQAL/KvwAAlrrsgAAboRYA==
  • Thread-topic: [Xen-devel] Error in XendCheckpoint: failed to flush file

> Use of the live flag to gate the flush/sync calls is not a good idea.
> We can
> 'live save' to disc (checkpointing) and we can 'non-live migrate' via
> socket. So the live flag is not really an indicator of what the file
> descriptor maps to (file vs. socket). Best to unconditionally try the
> flush/sync and ignore errors.

OK. Do you think it's worth checking the fd type with stat and only
doing the flush/fadvise if it's not a socket?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.